After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683137 - Use UserAvatarWidget to display user avatars
Use UserAvatarWidget to display user avatars
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-31 21:19 UTC by Giovanni Campagna
Modified: 2012-08-31 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use UserAvatarWidget to display user avatars (12.34 KB, patch)
2012-08-31 21:19 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-08-31 21:19:25 UTC 
Replace duplicate custom code with a common widget.
Comment 1 Giovanni Campagna 2012-08-31 21:19:27 UTC 
Created attachment 223107 [details] [review]
Use UserAvatarWidget to display user avatars
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-31 21:22:39 UTC 
Review of attachment 223107 [details] [review]:

Looks fine, one minor nit.

::: js/ui/endSessionDialog.js
@@ +248,3 @@
                                  y_fill: false });
 
+        this._iconBin = new St.Bin;

??
Comment 3 Giovanni Campagna 2012-08-31 21:31:51 UTC 
Attachment 223107 [details] pushed as 5e46abf - Use UserAvatarWidget to display user avatars