After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683065 - rtp: probation not disable if rtcp packet received
rtp: probation not disable if rtcp packet received
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.30
Other Linux
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-30 19:58 UTC by Aleix Conchillo Flaqué
Modified: 2012-08-30 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
disable probation whenever an rtcp packet is received (1.73 KB, patch)
2012-08-30 20:05 UTC, Aleix Conchillo Flaqué 		none Details | Review

Description Aleix Conchillo Flaqué 2012-08-30 19:58:19 UTC 
There's two ways to consider a source valid: probation (by checking consecutive sequence numbers) or when a valid RTCP packet is received, which disables probation.

Currently, both ways are implemented, however probation is only disable when RTCP packet is received when the source is new.
Comment 1 Aleix Conchillo Flaqué 2012-08-30 20:05:38 UTC 
Created attachment 222989 [details] [review]
disable probation whenever an rtcp packet is received

This patch sets probation to 0 whenever an RTCP packet is received, not only when the source is new.
Comment 2 Wim Taymans 2012-08-30 20:11:39 UTC 
Something like this:

commit cefbbb31c3306ec1ed003ded41e7c07971b56cec
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu Aug 30 22:07:24 2012 +0200

    session: also stop probatation on existing sources
    
    Receiving an RTCP packet should also stop probation on sources we have seen
    before.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=683065
Comment 3 Wim Taymans 2012-08-30 20:11:54 UTC 
Oops I was too fast