After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683055 - Badly named type macros for GrlCaps and GrlOperationOptions
Badly named type macros for GrlCaps and GrlOperationOptions
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-30 19:00 UTC by Mathias Hasselmann (IRC: tbf)
Modified: 2012-09-03 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.50 KB, patch)
2012-08-30 19:00 UTC, Mathias Hasselmann (IRC: tbf)
committed Details | Review

Description Mathias Hasselmann (IRC: tbf) 2012-08-30 19:00:04 UTC
Created attachment 222971 [details] [review]
proposed patch

The type macros for GrlCaps and GrlOperationOptions had "TYPE" add the end instead of the begin (right after the namespace).

Expected canonical names: GRL_TYPE_CAPS and GRL_TYPE_OPERATION_OPTIONS
Actual names: GRL_CAPS_TYPE and GRL_OPERATION_OPTIONS_TYPE
Comment 1 Juan A. Suarez Romero 2012-09-03 11:36:01 UTC
Unfortunately, this is a change in the API, so I will apply it to master, but not to 0.2.x branch.

Let's wait for the next stable API to have it included.

Apologies for inconveniences
Comment 2 Juan A. Suarez Romero 2012-09-03 11:51:36 UTC
commit ca606fb1cd8e8fea10df782acc35122f0175062b
Author: Mathias Hasselmann <mathias@openismus.com>
Date:   Thu Aug 30 20:56:52 2012 +0200

    Properly name some GType macros
    
    Those for GrlCaps and GrlOperationOptions had "TYPE" add the end
    instead of the begin (right after the namespace).
    
    This fixes https://bugzilla.gnome.org/show_bug.cgi?id=683055

 src/grl-caps.h              | 15 +++++++++------
 src/grl-operation-options.h | 15 +++++++++------
 2 files changed, 18 insertions(+), 12 deletions(-)