GNOME Bugzilla – Bug 682989
Add g_file_info_get_uri() and g_file_info_get_file() convenience methods
Last modified: 2012-12-12 09:55:48 UTC
A common complaint of GFileEnumerator and friends is that they don't allow you to get a GFile instance easily from the enumerator. The common pattern is to have: while ((info = g_file_enumerator_next_file (enumr, NULL, NULL)) { gchar *name = g_file_info_get_name (info); GFile *child = g_file_get_child (g_file_enumerator_get_container (enumr), nanme); } We can do much better. Introduce two new convenience methods that allow getitng the URI, and constructing a new GFile from that URI. Some local Gio things that construct GFileInfos are patched up, and there's a gvfs patch as well.
Created attachment 222858 [details] [review] gfileinfo: Add a standard::uri file info attribute As well as a g_file_info_get_file helper method that creates a new file using g_file_new_for_uri. This allows you to easily query a file, given a GFileInfo, like during the GFileEnumerator case.
Created attachment 222859 [details] [review] gio: Fill in the GFileInfo::standard::uri attribute In the three places that matter.
Created attachment 222860 [details] [review] gio: Add some tests for the new standard::uri attribute
Created attachment 222864 [details] [review] client: Fill in the new standard::uri attribute
Created attachment 223000 [details] [review] gfileinfo: Add a standard::uri file info attribute As well as a g_file_info_get_file helper method that creates a new file using g_file_new_for_uri. This allows you to easily query a file, given a GFileInfo, like during the GFileEnumerator case.
Created attachment 223001 [details] [review] gio: Fill in the GFileInfo::standard::uri attribute In the three places that matter.
Created attachment 223002 [details] [review] gio: Add some tests for the new standard::uri attribute
Created attachment 223003 [details] [review] client: Fill in the new standard::uri attribute
Roundtripping the uri via a GFileInfo field seems pretty weird. Not only do you get a weird field which is only filled in during enumeration, it also does a full GFile->uri->GFile roundtrip which is much more complicated than a single get_child() call. However, adding a helper like: GFile *g_file_enumerator_get_child (GFileEnumerator *enumerator, GFileInfo *info) to avoid unnecessary typing seems to make a lot of sense.
=> bug #682989