Bug 682938 – Crash when disconnecting account

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 682938 - Crash when disconnecting account


Summary:	Crash when disconnecting account


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	General
Version:	2.33.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-08-29 13:10 UTC by Guillaume Desmottes
Modified:	2012-08-29 14:01 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
roster-model-manager: always remove removed individual from the top group (1.24 KB, patch) 2012-08-29 13:53 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2012-08-29 13:10:31 UTC

I disconnected my XMPP account and empathy crashed.

+ Trace 230754

#0 type_get_qdata_L
at gtype.c line 3635
#1 type_check_is_value_type_U
at gtype.c line 4105
#2 g_type_check_is_value_type
at gtype.c line 4132
#3 g_value_type_compatible
at gvalue.c line 500
#4 g_value_object_collect_value
at gobject.c line 3339
#5 g_signal_emit_valist
at gsignal.c line 3275
#6 g_signal_emit
at gsignal.c line 3356
#7 empathy_roster_model_fire_groups_changed
at empathy-roster-model.c line 88
#8 top_individuals_changed_cb
at empathy-roster-model-manager.c line 194
#9 g_cclosure_marshal_VOID__PARAM
at gmarshal.c line 1042
#10 g_closure_invoke
at gclosure.c line 777
#11 signal_emit_unlocked_R
at gsignal.c line 3551
#12 g_signal_emit_valist
at gsignal.c line 3300
#13 g_signal_emit
at gsignal.c line 3356
#14 g_object_dispatch_properties_changed
at gobject.c line 1041
#15 g_object_notify_by_spec_internal
at gobject.c line 1135
#16 g_object_notify
at gobject.c line 1177
#17 check_top_individuals
at empathy-individual-manager.c line 229
#18 remove_individual
at empathy-individual-manager.c line 297
#19 aggregator_individuals_changed_cb
at empathy-individual-manager.c line 385
#20 g_cclosure_marshal_VOID__OBJECTv
at gmarshal.c line 1312
#21 _g_closure_invoke_va
at gclosure.c line 840
#22 g_signal_emit_valist
at gsignal.c line 3211
#23 g_signal_emit_by_name
at gsignal.c line 3393
#24 _folks_individual_aggregator_emit_individuals_changed
at individual-aggregator.c line 3298
#25 _folks_individual_aggregator_personas_changed_cb
#26 __folks_individual_aggregator_personas_changed_cb_folks_persona_store_personas_changed
at individual-aggregator.c line 2582
#27 g_cclosure_user_marshal_VOID__OBJECT_OBJECT_STRING_OBJECT_ENUM
at persona-store.c line 744
#28 g_closure_invoke
at gclosure.c line 777
#29 signal_emit_unlocked_R
at gsignal.c line 3551
#30 g_signal_emit_valist
at gsignal.c line 3300
#31 g_signal_emit_by_name
at gsignal.c line 3393
#32 _folks_persona_store_emit_personas_changed
at persona-store.c line 432
#33 _tpf_persona_store_load_cache_co
at tpf-persona-store.c line 3004
#34 _tpf_persona_store_load_cache_ready
at tpf-persona-store.c line 2866
#35 g_simple_async_result_complete
at gsimpleasyncresult.c line 767
#36 folks_object_cache_load_objects_co
at object-cache.c line 913
#37 folks_object_cache_load_objects_ready
at object-cache.c line 567
#38 g_simple_async_result_complete
at gsimpleasyncresult.c line 767
#39 load_contents_close_callback
at gfile.c line 6335
#40 async_ready_close_callback_wrapper
at ginputstream.c line 543
#41 g_simple_async_result_complete
at gsimpleasyncresult.c line 767
#42 complete_in_idle_cb_for_thread
at gsimpleasyncresult.c line 835
#43 g_idle_dispatch
at gmain.c line 4777
#44 g_main_dispatch
at gmain.c line 2691
#45 g_main_context_dispatch
at gmain.c line 3195
#46 g_main_context_iterate
at gmain.c line 3266
#47 g_main_context_iteration
at gmain.c line 3327
#48 g_application_run
at gapplication.c line 1607
#49 main
at empathy.c line 847

Comment 1 Guillaume Desmottes 2012-08-29 13:53:01 UTC

Created attachment 222760 [details] [review]
roster-model-manager: always remove removed individual from the top group

If the individual has been removed from the manager we should always remove it
from the top group members, even if he's still eligible for this group.

Comment 2 Laurent Contzen 2012-08-29 13:59:27 UTC

Review of attachment 222760 [details] [review]:

Looks good, thanks!

Comment 3 Laurent Contzen 2012-08-29 13:59:28 UTC

Review of attachment 222760 [details] [review]:

Looks good, thanks!

Comment 4 Guillaume Desmottes 2012-08-29 14:01:23 UTC

Attachment 222760 [details] pushed as 5f46f97 - roster-model-manager: always remove removed individual from the top group