After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682892 - Remove favicon support
Remove favicon support
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 682100 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-28 18:29 UTC by William Jon McCann
Modified: 2012-08-30 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove favicon support (4.26 KB, patch)
2012-08-28 18:29 UTC, William Jon McCann
committed Details | Review
screenshot (87.57 KB, image/png)
2012-08-28 18:30 UTC, William Jon McCann
  Details

Description William Jon McCann 2012-08-28 18:29:44 UTC
Using favicons for the default mount icon isn't very nice because they
aren't themable or resizable.
Comment 1 William Jon McCann 2012-08-28 18:29:46 UTC
Created attachment 222675 [details] [review]
Remove favicon support

16px favicons aren't themable or resizable. They don't work very well
as the default icons for files or mounts.
Comment 2 William Jon McCann 2012-08-28 18:30:10 UTC
Created attachment 222676 [details]
screenshot
Comment 3 William Jon McCann 2012-08-28 18:31:57 UTC
For reference, this feature was added in bug 557540.
Comment 4 William Jon McCann 2012-08-29 12:33:49 UTC
*** Bug 682100 has been marked as a duplicate of this bug. ***
Comment 5 Cosimo Cecchi 2012-08-30 13:58:02 UTC
Review of attachment 222675 [details] [review]:

ACK-ed on IRC by Alex and Tomas.