GNOME Bugzilla – Bug 682876
[i18n] some messages need translation context.
Last modified: 2012-08-28 15:53:52 UTC
Some messages (e.g. "None") need translation context. How to translate "None" into Japanese or other languages is dependent on the context.
Created attachment 222630 [details] [review] a patch for this bug. universal-access: add translation context for Zoom gray
Created attachment 222631 [details] [review] a patch for this bug network: add translation context for Wifi security
Created attachment 222632 [details] [review] a patch for this bug wacom: add translation context for Wacom action type
Created attachment 222633 [details] [review] a patch for this bug universal-access: add translation context for osk model
Please review the patches. Thanks in advance.
Review of attachment 222630 [details] [review]: ::: panels/universal-access/zoom-options.ui @@ +928,3 @@ <property name="can_focus">False</property> <property name="xalign">1</property> + <property name="label" translatable="yes" context="Zoom Grayscale" comments="short delay">None</property> It's not a delay. None means "No colour" (eg. grayscale only)... @@ +959,3 @@ <property name="can_focus">False</property> <property name="xalign">0</property> + <property name="label" translatable="yes" context="Zoom Grayscale" comments="long delay">Full</property> and "Full" means "full colour" (eg. no change, it's the default)
Review of attachment 222631 [details] [review]: ::: panels/network/net-device-wifi.c @@ +309,3 @@ g_string_set_size (str, str->len - 2); else { /* TRANSLATORS: this no (!) WiFi security */ You can probably remove the translator comment now that you have a context.
Review of attachment 222632 [details] [review]: ::: panels/wacom/cc-wacom-page.c @@ +605,3 @@ gtk_list_store_set (model, &new_row, MAPPING_DESCRIPTION_COLUMN, dir_name ? dir_name : button->name, + MAPPING_TYPE_COLUMN, g_dpgettext2 (NULL, "Wacom action-type", action_table[type].action_name), You should add a macro for that instead of calling g_dpgettext2 by hand.
Review of attachment 222633 [details] [review]: ::: panels/universal-access/uap.ui @@ +76,3 @@ </row> <row> + <col id="0" translatable="yes" context="universal access, on screen keyboard model">None</col> I'm pretty sure this code isn't used at all and should just be removed.
Created attachment 222640 [details] [review] modified patch > Review of attachment 222630 [details] [review]: > > ::: panels/universal-access/zoom-options.ui > @@ +928,3 @@ > <property > name="can_focus">False</property> > <property name="xalign">1</property> > + <property name="label" > translatable="yes" context="Zoom Grayscale" comments="short > delay">None</property> > > It's not a delay. None means "No colour" (eg. grayscale only)... > > @@ +959,3 @@ > <property > name="can_focus">False</property> > <property name="xalign">0</property> > + <property name="label" > translatable="yes" context="Zoom Grayscale" comments="long > delay">Full</property> > > and "Full" means "full colour" (eg. no change, it's the default) You are right. I removed the comments.
Created attachment 222641 [details] [review] modified patch > Review of attachment 222631 [details] [review]: > > ::: panels/network/net-device-wifi.c > @@ +309,3 @@ > g_string_set_size (str, str->len - 2); > else { > /* TRANSLATORS: this no (!) WiFi security */ > > You can probably remove the translator comment now that you have a context. All right. I removed it.
(In reply to comment #8) > Review of attachment 222632 [details] [review]: > > ::: panels/wacom/cc-wacom-page.c > @@ +605,3 @@ > gtk_list_store_set (model, &new_row, > MAPPING_DESCRIPTION_COLUMN, dir_name ? dir_name : > button->name, > + MAPPING_TYPE_COLUMN, g_dpgettext2 (NULL, "Wacom action-type", > action_table[type].action_name), > > You should add a macro for that instead of calling g_dpgettext2 by hand. I refered to other source files of gnome-control-center and other modules. But all the souces call g_dpgettext2 directly instead of defining a macro. For example: panels/display/cc-display-panel.c: 510: add_key (gtk_combo_box_get_model (GTK_COMBO_BOX (self->priv->rotation_combo)), g_dpgettext2 (NULL, "display panel, rotation", info->name), FALSE, 0, 0, 0, info->rotation); 513: selection = g_dpgettext2 (NULL, "display panel, rotation", info->name);
(In reply to comment #9) > Review of attachment 222633 [details] [review]: > > ::: panels/universal-access/uap.ui > @@ +76,3 @@ > </row> > <row> > + <col id="0" translatable="yes" context="universal access, on screen > keyboard model">None</col> > > I'm pretty sure this code isn't used at all and should just be removed. I see. I'll back down this patch. Whether you remove the unused elements, I leave it in your hands. Thank you.
Used a macro for the Wacom bits, and removed the unused universal-access object.