After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682673 - Remove more code for handling expanded list view rows
Remove more code for handling expanded list view rows
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-25 15:10 UTC by William Jon McCann
Modified: 2012-08-26 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove more code for handling expanded list view rows (13.09 KB, patch)
2012-08-25 15:11 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-08-25 15:10:58 UTC 
There was still some code remaining dealing with expanded rows. We should remove it
because it isn't needed and complicates the code.
Comment 1 William Jon McCann 2012-08-25 15:11:00 UTC 
Created attachment 222403 [details] [review]
Remove more code for handling expanded list view rows
Comment 2 Cosimo Cecchi 2012-08-25 19:35:20 UTC 
Review of attachment 222403 [details] [review]:

Nice cleanup...just one thing

::: src/nautilus-list-view.c
@@ -784,3 @@
 					g_list_free (selected_rows);
-				} else {
-					view->details->ignore_button_release = on_expander;

I think this private variable is unused too now.
Comment 3 William Jon McCann 2012-08-26 13:03:24 UTC 
Pushed with that change.