GNOME Bugzilla – Bug 682613
Fix some regressions in properties zoom animation
Last modified: 2016-03-31 13:54:48 UTC
The commit http://git.gnome.org/browse/gnome-boxes/commit/?id=188f9e352b91e9086185bb0b0912eda054ed79b5 introduced some regressions. The removed idle call gives this warning: (gnome-boxes:32010): Clutter-WARNING **: The actor '<below-bin>[<ClutterActor>:0xb469b0]' is currently inside an allocation cycle; calling clutter_actor_queue_relayout() is not recommended There is also an issue with the animation. It now animates position and size individually instead of the allocation rect, which causes a really weird looking animation (and is also the cause of the weird slowness in the commit comments).
Created attachment 222340 [details] [review] Fix warning about relayout in allocation cycle We can't relayout directly inside a size_allocate, instead we delay it with an idle.
Created attachment 222341 [details] [review] Fix up the properties zoom animation The go-to-properties zoom animates the screenshot position and size individually instead of the allocation rect, which causes a really weird looking animation. We also remove the workaround that was added to avoid a slow animation.
Review of attachment 222340 [details] [review]: ack, thanks for explanation
Review of attachment 222341 [details] [review]: ack, thanks for explanation
Attachment 222340 [details] pushed as 98dbdfb - Fix warning about relayout in allocation cycle Attachment 222341 [details] pushed as 582981b - Fix up the properties zoom animation