After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682613 - Fix some regressions in properties zoom animation
Fix some regressions in properties zoom animation
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-24 14:41 UTC by Alexander Larsson
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix warning about relayout in allocation cycle (1.43 KB, patch)
2012-08-24 14:47 UTC, Alexander Larsson
committed Details | Review
Fix up the properties zoom animation (2.35 KB, patch)
2012-08-24 14:47 UTC, Alexander Larsson
committed Details | Review

Description Alexander Larsson 2012-08-24 14:41:35 UTC
The commit 
http://git.gnome.org/browse/gnome-boxes/commit/?id=188f9e352b91e9086185bb0b0912eda054ed79b5

introduced some regressions.

The removed idle call gives this warning:
 (gnome-boxes:32010): Clutter-WARNING **: The actor '<below-bin>[<ClutterActor>:0xb469b0]' is currently inside an allocation cycle; calling clutter_actor_queue_relayout() is not recommended

There is also an issue with the animation. It now animates position and
size individually instead of the allocation rect, which causes a really weird
looking animation (and is also the cause of the weird slowness in the commit comments).
Comment 1 Alexander Larsson 2012-08-24 14:47:13 UTC
Created attachment 222340 [details] [review]
Fix warning about relayout in allocation cycle

We can't relayout directly inside a size_allocate, instead we
delay it with an idle.
Comment 2 Alexander Larsson 2012-08-24 14:47:16 UTC
Created attachment 222341 [details] [review]
Fix up the properties zoom animation

The go-to-properties zoom animates the screenshot position and
size individually instead of the allocation rect, which causes
a really weird looking animation. We also remove the workaround
that was added to avoid a slow animation.
Comment 3 Marc-Andre Lureau 2012-08-24 14:58:34 UTC
Review of attachment 222340 [details] [review]:

ack, thanks for explanation
Comment 4 Marc-Andre Lureau 2012-08-24 14:58:41 UTC
Review of attachment 222341 [details] [review]:

ack, thanks for explanation
Comment 5 Alexander Larsson 2012-08-24 15:00:01 UTC
Attachment 222340 [details] pushed as 98dbdfb - Fix warning about relayout in allocation cycle
Attachment 222341 [details] pushed as 582981b - Fix up the properties zoom animation