After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682578 - Fix extension installation and reloading
Fix extension installation and reloading
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-24 01:57 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-08-24 02:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extensionSystem: Make unloadExtension take an extension object, not a UUID (2.60 KB, patch)
2012-08-24 01:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
shellDBus: Fix reloadExtension (1.80 KB, patch)
2012-08-24 01:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
extensionDownloader: Fix extension installation (1.01 KB, patch)
2012-08-24 01:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-08-24 01:57:43 UTC 
See patches. I swore I tested these (I remember showing these features
off to people at some point), so I'm blaming it on review changes without
retesting it myself. I am a terrible person for doing this.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-24 01:57:47 UTC 
Created attachment 222271 [details] [review]
extensionSystem: Make unloadExtension take an extension object, not a UUID

For consistency with loadExtension.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-24 01:57:52 UTC 
Created attachment 222272 [details] [review]
shellDBus: Fix reloadExtension

We need to recreate and reimport the extension here, not just reimport
the same exact code.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-24 01:57:55 UTC 
Created attachment 222273 [details] [review]
extensionDownloader: Fix extension installation

The name of the method is "get_as_bytes"
Comment 4 Colin Walters 2012-08-24 02:03:33 UTC 
Review of attachment 222271 [details] [review]:

I'm just trusting you've tested these ones then =)
Comment 5 Colin Walters 2012-08-24 02:04:05 UTC 
Review of attachment 222272 [details] [review]:

Seems reasonable.
Comment 6 Colin Walters 2012-08-24 02:04:32 UTC 
Review of attachment 222273 [details] [review]:

Right.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-08-24 02:06:31 UTC 
Attachment 222271 [details] pushed as 4696bfb - extensionSystem: Make unloadExtension take an extension object, not a UUID
Attachment 222272 [details] pushed as 4ca2697 - shellDBus: Fix reloadExtension
Attachment 222273 [details] pushed as 67115b3 - extensionDownloader: Fix extension installation


That's probably the speediest review I've seen yet.