After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682524 - Matroska: Support tag targets
Matroska: Support tag targets
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-23 10:53 UTC by LRN
Modified: 2012-10-28 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Matroska tag TargetType support (9.64 KB, patch)
2012-08-23 12:43 UTC, LRN 		none Details | Review
Matroska tag TargetType support V2 (9.69 KB, patch)
2012-08-24 11:14 UTC, LRN 		none Details | Review
Correctly copy multi-valued tags (5.84 KB, patch)
2012-08-24 14:36 UTC, LRN 		none Details | Review
Unset GValue, fix the loop (3.15 KB, patch)
2012-08-25 00:12 UTC, LRN 		none Details | Review
Matroska tag TargetType support V2-1 (merged) (10.10 KB, patch)
2012-10-25 16:30 UTC, LRN 		committed Details | Review

Description LRN 2012-08-23 10:53:09 UTC 
This Matroska tagging system feature is the only way to specify things like GST_TAG_ALBUM_VOLUME_NUMBER, GST_TAG_ALBUM_VOLUME_COUNT, GST_TAG_TRACK_NUMBER, GST_TAG_TRACK_COUNT, GST_TAG_ALBUM_TITLE, GST_TAG_ALBUM_ARTIST.
Comment 1 LRN 2012-08-23 12:43:59 UTC 
Created attachment 222218 [details] [review]
Matroska tag TargetType support

* Reads TargetType and TargetTypeValue from a Tag.
* After Tag is completely read, processes taglist, substituting some of the
tags depending on target type value and the presence of video/subtitle streams.
* Supports reading two new simpletags - PART_NUMBER and TOTAL_PARTS

Depends on #682448
Comment 2 LRN 2012-08-24 11:14:22 UTC 
Created attachment 222299 [details] [review]
Matroska tag TargetType support V2

* Reads TargetType and TargetTypeValue from a Tag.
* After Tag is completely read, processes taglist, substituting some of the
tags depending on target type value and the presence of video/subtitle streams.
* Supports reading two new simpletags - PART_NUMBER and TOTAL_PARTS

V2:
* Fixed argument order for stream counter

Depends on #682448
Comment 3 LRN 2012-08-24 14:03:38 UTC 
There's a bug in gst_matroska_read_common_apply_target_type_foreach(). Turns out, gst_tag_list_copy_value() doesn't work correctly on multi-valued EXTENDED_COMMENTs (retains first value only).
I'll upload a patch later.
Comment 4 LRN 2012-08-24 14:36:02 UTC 
Created attachment 222338 [details] [review]
Correctly copy multi-valued tags

Update for attachment #222299 [details]
Fixes value copying.
Comment 5 LRN 2012-08-25 00:12:59 UTC 
Created attachment 222372 [details] [review]
Unset GValue, fix the loop

Patch on top of attachment #222338 [details]
Forgot to fix these.
Comment 6 LRN 2012-10-25 16:30:43 UTC 
Created attachment 227284 [details] [review]
Matroska tag TargetType support V2-1 (merged)
Comment 7 Sebastian Dröge (slomo) 2012-10-26 08:10:14 UTC 
commit 6c635ce64fb98a53a70444a3999dce858fac99f2
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Oct 26 10:09:39 2012 +0200

    matroskademux: Fix uninitialized variable compiler warning

commit 71fd688ef037aad4dd08fa2e9a2bb2b8a7c5f318
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Thu Aug 23 15:07:22 2012 +0400

    matroskademux: Matroska tag TargetType support
    
    * Reads TargetType and TargetTypeValue from a Tag.
    * After Tag is completely read, processes taglist, substituting some of the
    tags depending on target type value and the presence of video/subtitle streams.
    * Supports reading two new simpletags - PART_NUMBER and TOTAL_PARTS
    
    Depends on #682448
    Fixes #682524