After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682448 - Matroska: per-track tags support
Matroska: per-track tags support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-22 10:34 UTC by LRN
Modified: 2012-10-28 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Per-track tags for Matroska (6.03 KB, patch)
2012-08-22 10:35 UTC, LRN 		none Details | Review
Per-track tags for Matroska v2 (6.83 KB, patch)
2012-08-22 11:50 UTC, LRN 		none Details | Review
Per-track tags for Matroska v2-1 (1.87 KB, patch)
2012-08-23 20:20 UTC, LRN 		none Details | Review
Per-tracck tags for Matroska v2-2 (merged) (7.18 KB, patch)
2012-10-25 16:30 UTC, LRN 		committed Details | Review

Description LRN 2012-08-22 10:34:12 UTC 
Matroska parser should be able to apply tags only to specific tracks depending on target UIDs.
Comment 1 LRN 2012-08-22 10:35:29 UTC 
Created attachment 222128 [details] [review]
Per-track tags for Matroska

Requires Matroska file to have sane layout (track info before tag info).
Uses replace-merge.
Makes track UIDs 64-bit.
Fixes GST_MATROSKA_ID_TARGETEDITIONUID to match the spec.
Comment 2 LRN 2012-08-22 11:28:30 UTC 
Actually, now that i've had some time to think about it, it's _technically_ possible (though highly unlikely) for a single tag to apply to chapters, editions AND tracks simultaneously. My patch does not take that into account. I'll probably upload a fixed version sometime later.
Comment 3 LRN 2012-08-22 11:50:51 UTC 
Created attachment 222133 [details] [review]
Per-track tags for Matroska v2

Requires Matroska file to have sane layout (track info before tag info).
Uses replace-merge.
Makes track UIDs 64-bit.

v2:
Fixed version (allows a tag to apply to chapters, editions and tracks at
  the same time).
Fixes a warning string.
Comment 4 LRN 2012-08-23 20:20:04 UTC 
Created attachment 222257 [details] [review]
Per-track tags for Matroska v2-1

A patch against attachment #222133 [details], fixes the logic. Without it the code might throw critical warnings when toc is NULL and there are track targets.
Comment 5 LRN 2012-10-25 16:30:08 UTC 
Created attachment 227283 [details] [review]
Per-tracck tags for Matroska v2-2 (merged)
Comment 6 Sebastian Dröge (slomo) 2012-10-26 08:07:33 UTC 
commit b75628f041fbb8e2418fefd9759bbeb40d4c0475
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Aug 22 15:32:41 2012 +0400

    matroskademux: Per-track tags for Matroska
    
    Requires Matroska file to have sane layout (track info before tag info).
    Uses replace-merge.
    Makes track UIDs 64-bit.
    
    Fixes #682448