After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682412 - Fix modal dialog styling for network secret prompts
Fix modal dialog styling for network secret prompts
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 682466 683240 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-22 02:24 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-09-03 06:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix modal dialog styling for network secret prompts (1.55 KB, patch)
2012-08-22 02:24 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
Fix modal dialog styling for network secret prompts (1.55 KB, patch)
2012-08-22 02:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
network: Fix icon_size parameter (1.12 KB, patch)
2012-08-22 02:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-08-22 02:24:27 UTC 
We missed this one.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-22 02:24:29 UTC 
Created attachment 222085 [details] [review]
Fix modal dialog styling for network secret prompts
Comment 2 Colin Walters 2012-08-22 02:45:26 UTC 
Review of attachment 222085 [details] [review]:

::: js/ui/networkAgent.js
@@ +136,3 @@
                 secret.valid = true;
 
+            secretTable.add(label, { row: row, col: 0,

Did you mean to change "pos" to "row"?  I don't see that variable defined...
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-22 02:51:20 UTC 
Created attachment 222094 [details] [review]
Fix modal dialog styling for network secret prompts

Indeed I did. Whoops.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-08-22 02:51:33 UTC 
Created attachment 222095 [details] [review]
network: Fix icon_size parameter

We forgot to update this to NOTIFICATION_ICON_SIZE




And while I was testing, I found this.
Comment 5 Colin Walters 2012-08-22 03:16:44 UTC 
Review of attachment 222094 [details] [review]:

Looks fine now.
Comment 6 Colin Walters 2012-08-22 03:20:02 UTC 
Review of attachment 222095 [details] [review]:

Ok.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-08-22 03:34:32 UTC 
Attachment 222094 [details] pushed as 47ce72e - Fix modal dialog styling for network secret prompts
Attachment 222095 [details] pushed as 7126239 - network: Fix icon_size parameter
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-08-22 17:28:35 UTC 
*** Bug 682466 has been marked as a duplicate of this bug. ***
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-09-03 06:39:16 UTC 
*** Bug 683240 has been marked as a duplicate of this bug. ***