After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682385 - bad interaction between dwelling and scrolling when selecting text
bad interaction between dwelling and scrolling when selecting text
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 684338 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-21 18:56 UTC by Frederic Peters
Modified: 2012-09-19 01:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: fix dwelling during mouse-down (6.65 KB, patch)
2012-08-21 23:44 UTC, Owen Taylor
committed Details | Review

Description Frederic Peters 2012-08-21 18:56:30 UTC
I got bug 682383 and went to copy the stacktrace to submit the bug report (in a fullscreen terminal), but that move made the message tray appear (as I had the mouse stuck at the bottom of the screen). More importantly it was not possible to get the tray to disappear, and I was able to type in the terminal (and restart the shell).

I then reproduced the same issue while selecting text in gedit, there I found that the message tray would disappear when quitting gedit.

Perhaps the message tray shouldn't appear when a mouse button is down?
Comment 1 Owen Taylor 2012-08-21 23:44:26 UTC
Created attachment 222083 [details] [review]
messageTray: fix dwelling during mouse-down

If the user has the mouse down - for example when they are selecting
text and dragging - then the attempt to get a modal grab will fail.

grabHelper: allow the .grab() function to fail and do nothing in this
modal case if the grab fails.

messageTray: handle grab failure and don't pop up the tray. Change the
logic for tray dwelling so that we only try to pop up the tray once
while the pointer is in the dwell area - this avoids the possiility
that the tray will pop up once the user releases the mouse.
Comment 2 Cosimo Cecchi 2012-08-22 18:27:05 UTC
I encountered the same bug today by using an horizontal scrollbar in a maximized browser window.
When you move the scrollbar around at the bottom of the screen, the message tray popped up in an inconsistent state; I could still interact with the scrollbars, but couldn't get out of the message tray mode by pressing Escape.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-22 18:44:20 UTC
Review of attachment 222083 [details] [review]:

This is correct.
Comment 4 Owen Taylor 2012-08-23 05:49:40 UTC
Attachment 222083 [details] pushed as 3902e8b - messageTray: fix dwelling during mouse-down
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-09-19 01:39:39 UTC
*** Bug 684338 has been marked as a duplicate of this bug. ***