GNOME Bugzilla – Bug 682356
unmount prompt mentions a lot of implementation details
Last modified: 2021-07-05 14:40:23 UTC
Created attachment 221998 [details] screenshot I was trying to reproduce bug 586644 and I clicked Eject on the cdrom device. I was presented with the attached dialog. There are a few issues with it. * I didn't ask to unmount. I asked to eject. * /dev/loop0 is not the user visible name of the device * what other user?
Not much we can do in gnome-shell, this[0] is where the message comes from ... [0] http://cgit.freedesktop.org/udisks/tree/src/udiskslinuxfilesystem.c#n1685
[CC-ing David] This should probably be forwarded to the udisks bugzilla on freedesktop.org
This is a screenshot of an polkit authorization dialog. It is only shown for the corner case where the loop device is set up outside udisks via sudo losetup or similar. If gnome-disk-image-mounter(1) or udisks' Manager.LoopSetup() method had been used, authorization wouldn't have been needed and things would probably have been working as you expected. I don't think there is any bug with gvfs or udisks here. It should probably be closed NOTGNOME.
Agree this is a corner case. However, we should be sure that more typical cases never use the terms "unmount" or "mount" since those are no longer user visible actions. And if there is a mention of another user we should try to be more specific. And if we ever mention raw devices - don't :)
Yeah, the messages in the udisks authorization dialogs can be improved - for physical drives, we right now show the drive name (not very helpful either but it's the best we have) and the device name in parenthesis (to avoid ambiguity) - see http://people.freedesktop.org/~david/gnome-disks-ata-secure-erase-confirmation.png In this case, maybe we could use the filesystem label (if there is one) to refer to the device - short of that, there's really nothing suitable except perhaps "Loop Device 0" which isn't any better than /dev/loop0. We'd probably still want the device name, just in case. As discussed on IRC you proposed to use the verb "remove" instead of "unmount" in the message. I'm not sure that would be right in this context. I'd actually rather have gvfs-udisks2-volume-monitor set an option hint.eject=TRUE to the Filesystem.Unmount() D-Bus method and then we'd use "eject" instead of "unmount". Anyway, I've filed https://bugs.freedesktop.org/show_bug.cgi?id=53949 so we don't forget.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.