After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682253 - Placement of close buttons is off
Placement of close buttons is off
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-20 12:22 UTC by Allan Day
Modified: 2012-08-20 22:07 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
messageTray: Port the close buttons over to Clutter properties (12.35 KB, patch)
2012-08-20 20:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
messageTray: Put the notification widget in the center (3.13 KB, patch)
2012-08-20 20:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
messageTray: Adjust the position of the close button (1.71 KB, patch)
2012-08-20 20:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Allan Day 2012-08-20 12:22:48 UTC 
The close buttons are too far outside of the notification; this leaves them looking a bit like they are hanging off the side.

Try shifting the close button down 8px and 2px to the left. You can see how they're supposed to look here:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/notifications-critical-expanded.png
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-20 20:50:09 UTC 
Created attachment 221910 [details] [review]
messageTray: Port the close buttons over to Clutter properties

Rather than computing everything manually, let Clutter calculate
things for us.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-20 20:50:12 UTC 
Created attachment 221911 [details] [review]
messageTray: Put the notification widget in the center

Rather than stretching the entire screen length
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-20 20:50:15 UTC 
Created attachment 221912 [details] [review]
messageTray: Adjust the position of the close button

Make this closer to the mockups.
Comment 4 Florian Müllner 2012-08-20 21:52:06 UTC 
Review of attachment 221910 [details] [review]:

Looks good
Comment 5 Florian Müllner 2012-08-20 21:57:46 UTC 
Review of attachment 221911 [details] [review]:

Sure.
Comment 6 Florian Müllner 2012-08-20 21:59:13 UTC 
Review of attachment 221912 [details] [review]:

yup
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-08-20 22:07:09 UTC 
Attachment 221910 [details] pushed as becaeaf - messageTray: Port the close buttons over to Clutter properties
Attachment 221911 [details] pushed as d721fc2 - messageTray: Put the notification widget in the center
Attachment 221912 [details] pushed as a2e0e0a - messageTray: Adjust the position of the close button