After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682236 - Focusing the text entry should force a chat notification to stay open
Focusing the text entry should force a chat notification to stay open
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-20 10:08 UTC by Allan Day
Modified: 2012-09-06 10:06 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
messageTray: Focusing the text entry should force chats to stay open (3.19 KB, patch)
2012-09-05 17:00 UTC, Debarshi Ray
accepted-commit_now Details | Review
messageTray: Focusing the text entry should force chats to stay open (2.94 KB, patch)
2012-09-06 09:54 UTC, Debarshi Ray
committed Details | Review

Description Allan Day 2012-08-20 10:08:11 UTC
If you have the text entry of a chat notification focused, you really don't want the notification to disappear. This can easily happen right now, because we are relying on having the pointer hovering over the notification to keep it open.

Also, this is broken on touch screens.
Comment 1 Debarshi Ray 2012-09-05 17:00:06 UTC
Created attachment 223563 [details] [review]
messageTray: Focusing the text entry should force chats to stay open
Comment 2 drago01 2012-09-06 07:16:11 UTC
Review of attachment 223563 [details] [review]:

Looks good.
Comment 3 Debarshi Ray 2012-09-06 09:54:14 UTC
Created attachment 223618 [details] [review]
messageTray: Focusing the text entry should force chats to stay open
Comment 4 drago01 2012-09-06 10:00:47 UTC
Review of attachment 223618 [details] [review]:

Looks good.
Comment 5 Debarshi Ray 2012-09-06 10:06:19 UTC
commit 5030d59fcc29e59aea7d5e2d3f425ce1ededa56d
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Wed Sep 5 18:59:50 2012 +0200

    messageTray: Focusing the text entry should force chats to stay open
    
    https://bugzilla.gnome.org/show_bug.cgi?id=682236