After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682217 - vapigen.m4, Rsvg-2.0-custom.vala, Rsvg-2.0.metadata missing from librsvg-2.36.2 tarball
vapigen.m4, Rsvg-2.0-custom.vala, Rsvg-2.0.metadata missing from librsvg-2.36...
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
2.36.x
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-20 00:02 UTC by Alexandre Rostovtsev
Modified: 2012-08-20 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (729 bytes, patch)
2012-08-20 00:03 UTC, Alexandre Rostovtsev
none Details | Review

Description Alexandre Rostovtsev 2012-08-20 00:02:40 UTC
m4/vapigen.m4, Rsvg-2.0-custom.vala, Rsvg-2.0.metadata should be added to EXTRA_DIST, otherwise they do not get added to the release tarballs.
Comment 1 Alexandre Rostovtsev 2012-08-20 00:03:45 UTC
Created attachment 221773 [details] [review]
proposed patch
Comment 2 Christian Persch 2012-08-20 10:58:19 UTC
+	Rsvg-2.0-custom.vala		\
+	Rsvg-2.0.metadata		\

Ok for these two.

+	m4/vapigen.m4

But not for this one. This is only required when building from git, not tarball, so shouldn't be disted. If you want to reautogen, you'll need to have the vala macros installed.

With that fixed, ok to commit to master.
Comment 3 Alexandre Rostovtsev 2012-08-20 14:46:06 UTC
Committed with the above change: http://git.gnome.org/browse/librsvg/commit/?id=4c776f81c0ec28c8a1f9f968a30de7cb3f216191