GNOME Bugzilla – Bug 682081
gtlscertificate: certificate-bytes read-only, revert private-key-bytes
Last modified: 2012-08-21 12:35:44 UTC
* In order to add contstruct properties to an abstract base calls, and retain ABI stability, the base class must add a default implementation of those properties. * We cannot add a default implementation of certificate-bytes or private-key-bytes since certificate and private-key properties are writable on construct-only. * So change certificate-bytes to be read-only * Revert private-key-bytes, since it is not readable. * Add test to make sure base class default implementation works.
Created attachment 221569 [details] [review] gtlscertificate: certificate-bytes read-only, revert private-key-bytes
Created attachment 221579 [details] [review] gtlscertificate: certificate-bytes read-only, revert private-key-bytes * This mirrors a commit in glib, which reverts some changes because they broke ABI.
hm... it's weird to have a read-only certificate-bytes property... maybe we should just remove the whole thing? (You could still have a gnutls-specific g_tls_certificate_gnutls_get_bytes() in the gnutls backend for internal use.)
Created attachment 221983 [details] [review] Revert "gtlscertificate: Add certificate-bytes and private-key-bytes props" * In order to add contstruct properties to an abstract base calls, and retain ABI stability, the base class must add a default implementation of those properties. * We cannot add a default implementation of certificate-bytes or private-key-bytes since certificate and private-key properties are writable on construct-only. This reverts commit 541c985869fe9f2c0a858c0a91b4eb60f99d19f0.
Created attachment 221984 [details] [review] Revert "gnutls: Implement certificate-bytes and private-key-bytes properties" * The corresponding commit was reverted in glib due to ABI issues * Add g_tls_certificate_gnutls_get_bytes() for glib-networking use. * Fix up the tests and other code so it works in the presence of this reverted commit. This reverts commit c30a4bbaf5e6f937f9e15d4c5fba7ab40a52b6d3.
Comment on attachment 221983 [details] [review] Revert "gtlscertificate: Add certificate-bytes and private-key-bytes props" Attachment 221983 [details] pushed as 7518f7a - Revert "gtlscertificate: Add certificate-bytes and private-key-bytes props"
Attachment 221984 [details] pushed as 6e00a33 - Revert "gnutls: Implement certificate-bytes and private-key-bytes properties"