After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681782 - Load the session asynchronously
Load the session asynchronously
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 641734
Blocks: 641739
 
 
Reported: 2012-08-13 17:12 UTC by Carlos Garcia Campos
Modified: 2013-01-08 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (30.07 KB, patch)
2012-08-13 17:12 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch for current git master (27.87 KB, patch)
2012-09-03 10:29 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch (27.90 KB, patch)
2012-10-08 09:24 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch (27.85 KB, patch)
2012-11-26 10:24 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch (26.88 KB, patch)
2012-12-20 13:19 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-08-13 17:12:13 UTC 
Created attachment 221040 [details] [review]
Patch

Using a sax parser that we can feed using a GInputStream instead of reading the whole file from disck and creating a xml dom document.
Comment 1 Carlos Garcia Campos 2012-09-03 10:29:07 UTC 
Created attachment 223275 [details] [review]
Updated patch for current git master

Tool windows are not tracked by the session anymore and use ephy_string_to_int() instead of custom implementation that has been removed.
Comment 2 Carlos Garcia Campos 2012-10-08 09:24:59 UTC 
Created attachment 226023 [details] [review]
Updated patch

Updated for the changes in bug #641734 (ephy_shell_has_windows() has been removed)
Comment 3 Carlos Garcia Campos 2012-11-26 10:24:03 UTC 
Created attachment 229887 [details] [review]
Updated patch

Patch updated after a60eb7cad58e17985e8a7908d5e90bab5fff6186 (ephy_shell_get_active_window() has been removed)
Comment 4 Carlos Garcia Campos 2012-12-20 13:19:53 UTC 
Created attachment 231980 [details] [review]
Updated patch
Comment 5 Xan Lopez 2013-01-08 15:15:08 UTC 
Review of attachment 231980 [details] [review]:

OK, I haven't reviewed it thoroughly but the code in general seems sensible, and if the tests pass it cannot be too broken! So looks good to me, just have the minor comment below.

::: src/ephy-session.c
@@ -1005,3 @@
- *
- * Return value: TRUE if at least a window has been opened
- **/

No need to lose this gtk-doc comment no? Just add the new stuff to it.
Comment 6 Carlos Garcia Campos 2013-01-08 16:41:31 UTC 
Comment on attachment 231980 [details] [review]
Updated patch

Added API docs and pushed to git master.