After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681597 - Patch: Board changing has only two directions
Patch: Board changing has only two directions
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: lightsoff
3.5.x
Other Linux
: Normal trivial
: ---
Assigned To: GNOME Games maintainers
Robert Carr
Depends on:
Blocks:
 
 
Reported: 2012-08-10 13:01 UTC by Adam Matoušek
Modified: 2012-08-12 23:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (maybe it's redundant) (1.15 KB, patch)
2012-08-10 13:04 UTC, Adam Matoušek 		committed Details | Review

Description Adam Matoušek 2012-08-10 13:01:13 UTC 
Hello,
the transition of won board should have any direction, except for the last used, however, there is a bad operator in the condition which ensures it, so there are only two directions (left and down). That's a trivial bug, so there's a patch in the following post.
Comment 1 Adam Matoušek 2012-08-10 13:04:34 UTC 
Created attachment 220872 [details] [review]
The patch (maybe it's redundant)
Comment 2 Robert Ancell 2012-08-12 23:35:01 UTC 
Review of attachment 220872 [details] [review]:

The code was copied from the original javascript version:
http://git.gnome.org/browse/gnome-games/tree/lightsoff/src/Game.js?h=gnome-3-2#n88

But your patch seems correct, so I've applied it, thanks!
Comment 3 Robert Ancell 2012-08-12 23:35:15 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.