GNOME Bugzilla – Bug 681556
Use upstream tools: autoreconf and gettext
Last modified: 2018-05-22 12:51:40 UTC
Created attachment 220840 [details] [review] Use-autoreconf-instead-gnome-autogen Use the upstream tools
Created attachment 220841 [details] [review] Use-upstream-gettext
Looks like the first patch was already pushed to git master. The second patch is almost certainly wrong. Why are you removing the definition and AC_SUBST of ALL_LINGUAS? It's needed by xslt/common/domains/Makefile.am.
Created attachment 269821 [details] [review] Use upstream gettext instead glibone and intltool Here an updated patch. Sorry for the delay
Hi, Any chance this can get a review?
Review of attachment 269821 [details] [review]: I suppose that you did not test a distcheck, because it fails: make[3]: Entering directory '/home/david/checkout/gnome/yelp-xsl/doc/yelp-xsl' make[3]: Leaving directory '/home/david/checkout/gnome/yelp-xsl/doc/yelp-xsl' make[2]: Leaving directory '/home/david/checkout/gnome/yelp-xsl/doc' (cd po && make top_distdir=../yelp-xsl-3.17.90 distdir=../yelp-xsl-3.17.90/po \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/home/david/checkout/gnome/yelp-xsl/po' Makefile:142: *** target pattern contains no '%'. Stop. make[2]: Leaving directory '/home/david/checkout/gnome/yelp-xsl/po' Makefile:536: recipe for target 'distdir' failed make[1]: *** [distdir] Error 1 make[1]: Leaving directory '/home/david/checkout/gnome/yelp-xsl' Makefile:634: recipe for target 'dist' failed make: *** [dist] Error 2
Created attachment 332347 [details] [review] Use upstream gettext.v2 Sorry, my bad; new patch attached
Review of attachment 332347 [details] [review]: ::: po/Makevars @@ +19,3 @@ +# the public domain; in this case the translators are expected to disclaim +# their copyright. +COPYRIGHT_HOLDER = Free Software Foundation, Inc. Er, nope.
(In reply to David King from comment #7) > Review of attachment 332347 [details] [review] [review]: > > ::: po/Makevars > @@ +19,3 @@ > +# the public domain; in this case the translators are expected to disclaim > +# their copyright. > +COPYRIGHT_HOLDER = Free Software Foundation, Inc. > > Er, nope. What should I put there, please?
(In reply to Javier Jardón (IRC: jjardon) from comment #8) > What should I put there, please? Shaun McCance wrote all the translatable strings, as far as I can tell from the git log. However, I have not checked thoroughly.
Created attachment 359619 [details] [review] Use upstream gettext.v3
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/yelp-xsl/issues/17.