After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681455 - 'make distcheck' fails trying to install vapi
'make distcheck' fails trying to install vapi
Status: RESOLVED FIXED
Product: libgnome-keyring
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-08 15:13 UTC by Stef Walter
Modified: 2019-02-22 11:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vala: install vapis to $prefix/share/vala/vapi not system vapidir (1.01 KB, patch)
2012-08-08 18:12 UTC, Evan Nemerson 		committed Details | Review

Description Stef Walter 2012-08-08 15:13:51 UTC 
libgnome-keyring distcheck fails when trying to install a vapi to the system. It seems not be respecting DESTDIR:

test -z "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/share/gir-1.0" || /usr/bin/mkdir -p "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/share/gir-1.0"
 /usr/bin/install -c -m 644 GnomeKeyring-1.0.gir '/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/share/gir-1.0'
test -z "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/include/gnome-keyring-1/" || /usr/bin/mkdir -p "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/include/gnome-keyring-1/"
 /usr/bin/install -c -m 644 ../../library/gnome-keyring.h ../../library/gnome-keyring-memory.h ../../library/gnome-keyring-result.h '/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/include/gnome-keyring-1/'
test -z "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/pkgconfig" || /usr/bin/mkdir -p "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/pkgconfig"
 /usr/bin/install -c -m 644 gnome-keyring-1.pc '/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/pkgconfig'
test -z "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/girepository-1.0" || /usr/bin/mkdir -p "/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/girepository-1.0"
 /usr/bin/install -c -m 644 GnomeKeyring-1.0.typelib '/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_inst/lib/girepository-1.0'
test -z "/usr/share/vala/vapi" || /usr/bin/mkdir -p "/usr/share/vala/vapi"
 /usr/bin/install -c -m 644 gnome-keyring-1.vapi '/usr/share/vala/vapi'
/usr/bin/install: cannot create regular file ‘/usr/share/vala/vapi/gnome-keyring-1.vapi’: Permission denied
make[4]: *** [install-vapiDATA] Error 1
make[4]: Leaving directory `/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_build/library'
make[3]: *** [install-am] Error 2
make[3]: Leaving directory `/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_build/library'
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_build/library'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/data/projects/libgnome-keyring/libgnome-keyring-3.5.4/_build'
make: *** [distcheck] Error 1
Comment 1 Evan Nemerson 2012-08-08 18:12:49 UTC 
Created attachment 220717 [details] [review]
vala: install vapis to $prefix/share/vala/vapi not system vapidir

Looks like a bug in vapigen.m4...  which gets copied to a bunch of projects.  Assuming this works I'll update the copy shipped with valac and file bugs for the other projects which have copied it.
Comment 2 Stef Walter 2012-08-08 19:24:00 UTC 
Thanks. That seems to do the trick. Oddly enough the problem persisted
until I distcleaned. But that's probably to be expected with m4 and
how autoconf caches things.


Attachment 220717 [details] pushed as 632c284 - vala: install vapis to $prefix/share/vala/vapi not system vapidir