GNOME Bugzilla – Bug 681453
wayland: More fixes based on wayland-0.95.0 and gstreamer-1.0 apis
Last modified: 2012-08-21 09:46:13 UTC
Created attachment 220688 [details] [review] wayland: More fixes based on wayland-0.95.0 and gstreamer-1.0 apis -- bump wayland version to 0.95.0 which will lead to stable 1.0 release -- Avoid memcopy and use propose_allocation for GstBufferPool allocation -- Using WaylandBufferPool -- shm: Allocate shm buffers through new wl_shm_pool interface(the shm buffer allocation is a two step process now: first allocate a wl_shm_pool, then allocate a buffer from the pool.) *videometa handling is not yet implemented *need more fixes here and there But the wayland protocol/main APIs won't change much since wayland is approaching 1.0 release(stable one).
Created attachment 220689 [details] [review] Correct the version checking
Any update? Is it possible to push this?
Created attachment 221550 [details] [review] wayland: respond to ping/pong protocol so we're not deemed unresponsive
Created attachment 221551 [details] [review] wayland: use scale fullscreen method
Please don't squash the last two patches together with the older patches...
Haven't reviewed these, but don't see a reason not to just push them for now: commit 547d679e9ec7e008209fb8504afdfe00fa86b5bf Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Fri Aug 17 11:12:22 2012 +0300 wayland: use scale fullscreen method. This makes the compositor scale the surface to fit and preserves aspect ratio. https://bugzilla.gnome.org/show_bug.cgi?id=681453 commit dc81682f4b2adf526a185366ac5713856fa2cdee Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Fri Aug 17 11:10:39 2012 +0300 wayland: respond to ping/pong protocol so we're not deemed unresponsive. https://bugzilla.gnome.org/show_bug.cgi?id=681453 commit 1cc573d02f99a3e5c95e54b60ba2b3a41ed796c1 Author: Tim-Philipp Müller <tim@centricular.net> Date: Tue Aug 21 10:37:10 2012 +0100 configure: fix check for wayland We only seem to need wayland-client. Also make work with wayland being installed in a non-default prefix by not overwriting/clearing WAYLAND_{CFLAGS,LIBS} for no reason at all. commit c803ca4af55520e8eb7c69911491ae118c3a4fd8 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Wed Aug 8 17:10:28 2012 +0300 wayland: More fixes based on wayland-0.95.0 and gstreamer-1.0 apis - bump wayland version to 0.95.0 which will lead to stable 1.0 release - avoid memcopy and use propose_allocation for GstBufferPool allocation - using WaylandBufferPool - shm: Allocate shm buffers through new wl_shm_pool interface (the shm buffer allocation is a two step process now: first allocate a wl_shm_pool, then allocate a buffer from the pool) https://bugzilla.gnome.org/show_bug.cgi?id=681453
Comment on attachment 220689 [details] [review] Correct the version checking Squashed this with the previous patch, which you could have done as well really, since you're just fixing a mistake in your own patch :)
(In reply to comment #7) > (From update of attachment 220689 [details] [review]) > Squashed this with the previous patch, which you could have done as well > really, since you're just fixing a mistake in your own patch :) That is perfectly fine... :) ..thanks for the push...!