After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681221 - Moving the window group causes flickering around the window actors
Moving the window group causes flickering around the window actors
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-05 08:56 UTC by tombeckmann
Modified: 2012-08-16 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to solve this issue (1.24 KB, patch)
2012-08-05 08:56 UTC, tombeckmann 		none Details | Review
Updated patch (1.65 KB, patch)
2012-08-05 16:32 UTC, tombeckmann 		committed Details | Review
MetaWindowGroup: fix logic for handling translations (2.14 KB, patch)
2012-08-15 17:30 UTC, Owen Taylor 		committed Details | Review

Description tombeckmann 2012-08-05 08:56:44 UTC 
Created attachment 220346 [details] [review]
A patch to solve this issue

When moving the window group, the background actor shows black boxes at the old places of the window actors.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-05 15:15:16 UTC 
Why not add (or subtract, I forget) the window group's position? That should cause everything to line up correctly.
Comment 2 tombeckmann 2012-08-05 16:32:16 UTC 
Created attachment 220370 [details] [review]
Updated patch

That's true... I updated the patch.
Comment 3 Florian Müllner 2012-08-06 18:25:32 UTC 
Review of attachment 220370 [details] [review]:

Patch makes sense to me, a slightly more verbose commit message would be nice though :-)

(on a side note, I'll do a release later today, this looks like a good candidate to include ...)
Comment 4 Owen Taylor 2012-08-15 17:30:17 UTC 
Created attachment 221294 [details] [review]
MetaWindowGroup: fix logic for handling translations

Instead of getting the x/y of the MetaBackgroundActor with respect to the
parent, use the same logic that we do for windows, fixing the case
where there is a more complex transformation involved.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-08-15 18:50:05 UTC 
Review of attachment 221294 [details] [review]:

Looks good.
Comment 6 Owen Taylor 2012-08-16 00:44:28 UTC 
Attachment 221294 [details] pushed as 0ab572d - MetaWindowGroup: fix logic for handling translations