After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680922 - Label is sometimes left behind while destroying the GtkNotebook
Label is sometimes left behind while destroying the GtkNotebook
Status: RESOLVED DUPLICATE of bug 680349
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-07-31 16:23 UTC by Gustavo Noronha (kov)
Modified: 2012-08-01 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make sure the tab label is removed in all cases (1.92 KB, patch)
2012-07-31 16:26 UTC, Gustavo Noronha (kov)
none Details | Review

Description Gustavo Noronha (kov) 2012-07-31 16:23:19 UTC
Epiphany's remove tab implementation asserts that the widget that's being removed is an EphyEmbed:

	g_assert (EPHY_IS_EMBED (tab_widget));

After 325cf071d1b6de55eac2a97d8f38558efda17807 this assertion is being hit when the window is closed (it works fine if you close the tab, though). It seems to be because the new logic in remove_tab_label is too aggressive in avoiding unparenting/removing the tab label. I'm not 100% on what needs to be done, but I'll post a possible patch.
Comment 1 Gustavo Noronha (kov) 2012-07-31 16:26:27 UTC
Created attachment 220000 [details] [review]
Make sure the tab label is removed in all cases
Comment 2 Cosimo Cecchi 2012-08-01 17:04:26 UTC
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 680349 ***