GNOME Bugzilla – Bug 680871
Current gvfs fails to build against gphoto2 2.5.0
Last modified: 2012-08-23 09:42:38 UTC
Since Fedora Rawhide bumped to gphoto2 2.5.0, builds of gvfs are failing with these errors: gvfsbackendgphoto2.c: In function 'do_mount': gvfsbackendgphoto2.c:1650:35: error: request for member 'name' in something not a structure or union gvfsbackendgphoto2.c:1650:46: error: request for member 'path' in something not a structure or union gvfsbackendgphoto2.c:1650:57: error: request for member 'library_filename' in something not a structure or union gvfsbackendgphoto2.c: In function 'do_slow_file_rename_in_same_dir': gvfsbackendgphoto2.c:2593:3: warning: passing argument 3 of 'gp_camera_folder_put_file' from incompatible pointer type [enabled by default] In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: expected 'const char *' but argument is of type 'struct CameraFile *' gvfsbackendgphoto2.c:2593:3: error: incompatible type for argument 4 of 'gp_camera_folder_put_file' In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: expected 'CameraFileType' but argument is of type 'struct GPContext *' gvfsbackendgphoto2.c:2593:3: error: too few arguments to function 'gp_camera_folder_put_file' In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: declared here gvfsbackendgphoto2.c: In function 'commit_write_handle': gvfsbackendgphoto2.c:3225:3: warning: implicit declaration of function 'gp_file_set_type' [-Wimplicit-function-declaration] gvfsbackendgphoto2.c:3232:3: warning: passing argument 3 of 'gp_camera_folder_put_file' from incompatible pointer type [enabled by default] In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: expected 'const char *' but argument is of type 'struct CameraFile *' gvfsbackendgphoto2.c:3232:3: error: incompatible type for argument 4 of 'gp_camera_folder_put_file' In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: expected 'CameraFileType' but argument is of type 'struct GPContext *' gvfsbackendgphoto2.c:3232:3: error: too few arguments to function 'gp_camera_folder_put_file' In file included from /usr/include/gphoto2/gphoto2-library.h:29:0, from /usr/include/gphoto2/gphoto2.h:49, from gvfsbackendgphoto2.c:37: /usr/include/gphoto2/gphoto2-camera.h:351:5: note: declared here make[4]: *** [gvfsd_gphoto2-gvfsbackendgphoto2.o] Error 1 See http://kojipkgs.fedoraproject.org//work/tasks/4446/4334446/build.log . Build of 1.13.3 fails and I see no changes to gvfsbackendgphoto2.c in git since April (except an FSF address change), so I conclude it's still broken in git. Thanks!
References on the API changes in gphoto 2.5.0 are available at http://www.gphoto.org/news/ , if that's any use.
Fixed in: http://git.gnome.org/browse/gvfs/commit/?id=259a09183f7c96b5fb0f6453bb4b0bcf92e3eaa2 http://git.gnome.org/browse/gvfs/commit/?id=ef1578c9fef421a22c030d728fb5ef77bb7b86f6 Could someone please close?
Yeah, this should work fine now, closing.