After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680847 - Port to GStreamer 1.0
Port to GStreamer 1.0
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks: 679412
 
 
Reported: 2012-07-30 16:26 UTC by Tim-Philipp Müller
Modified: 2012-08-21 21:25 UTC
See Also:
GNOME target: 3.6
GNOME version: 3.5/3.6

Attachments
Port brasero to GStreamer 1.0 (40.24 KB, patch)
2012-08-02 10:46 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2012-07-30 16:26:23 UTC 
I've made a start on this.
Comment 1 Tim-Philipp Müller 2012-08-02 10:46:00 UTC 
Created attachment 220138 [details] [review]
Port brasero to GStreamer 1.0

Tentative patch. Compiles. Basically untested (only tested audio preview/playback so far).

There's some rather weird code (brasero_transcode_buffer_handler) in some places that doesn't look like it makes much sense. I've left it intact for the time being and tried to port it over regardless. Will try to see if I can find someone who remembers the rationale for that code.
Comment 2 André Klapper 2012-08-20 10:03:27 UTC 
ping - any Brasero maintainer around to review / test / commit this?
Comment 3 Luis Medinas 2012-08-20 12:43:33 UTC 
Andre: I will review this, sorry for the delay.
Comment 4 Luis Medinas 2012-08-21 19:23:48 UTC 
Review of attachment 220138 [details] [review]:

Thank your for the patch. I don't know the Gstreamer 1.0 API but the patch looks ok and i don't have time to work on it for 3.6. Please commit and thank you.
Comment 5 Javier Jardón (IRC: jjardon) 2012-08-21 21:10:46 UTC 
Comment on attachment 220138 [details] [review]
Port brasero to GStreamer 1.0

commit 526d70150af05fd6700c37deac7c0d6c540a4198
Comment 6 Tim-Philipp Müller 2012-08-21 21:21:00 UTC 
Thanks!

I'm not following brasero bugs, please feel free to CC me to any bugs reported against the 1.0 version.
Comment 7 Luis Medinas 2012-08-21 21:25:32 UTC 
(In reply to comment #6)
> Thanks!
> 
> I'm not following brasero bugs, please feel free to CC me to any bugs reported
> against the 1.0 version.

Will do thanks a lot for your work :)