After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680801 - st: Support repeated backgrounds
st: Support repeated backgrounds
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-29 18:42 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-08-03 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Fix borders test (1.09 KB, patch)
2012-07-29 18:42 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-theme-node: Clean up (2.23 KB, patch)
2012-07-29 18:42 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-theme-node: Add repeating backgrounds (10.01 KB, patch)
2012-07-29 18:42 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-29 18:42:12 UTC 
The lock screen and new message tray have a very subtle noise texture in the background (so subtle that Giovanni missed it while implementing the designs!). In order to implement it, we need to support repeating backgrounds.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-29 18:42:15 UTC 
Created attachment 219857 [details] [review]
tests: Fix borders test

Bad merge
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-07-29 18:42:18 UTC 
Created attachment 219858 [details] [review]
st-theme-node: Clean up

Replace some faulty indentation, group some booleans to reduce
a bit of memory usage
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-07-29 18:42:22 UTC 
Created attachment 219859 [details] [review]
st-theme-node: Add repeating backgrounds

Add support for the CSS "background-repeat" property. Currently, this
only supports on/off, rather than allowing tiling in each individual
dimension. It is supported for both the cogl and cairo rendering paths.
Comment 4 Giovanni Campagna 2012-08-03 15:20:53 UTC 
Review of attachment 219857 [details] [review]:

Nice. Says a lot of how often the test suite is run...
Comment 5 Giovanni Campagna 2012-08-03 15:21:50 UTC 
Review of attachment 219858 [details] [review]:

LGTM
Comment 6 Giovanni Campagna 2012-08-03 15:24:11 UTC 
Review of attachment 219859 [details] [review]:

Looks good
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-08-03 15:27:37 UTC 
Attachment 219857 [details] pushed as 114fb42 - tests: Fix borders test
Attachment 219858 [details] pushed as 3ffa1e3 - st-theme-node: Clean up
Attachment 219859 [details] pushed as 7dbc78c - st-theme-node: Add repeating backgrounds