After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680671 - configure should check for the python-devel package if called with --enable-python
configure should check for the python-devel package if called with --enable-p...
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
git-master
Other All
: Normal normal
: ---
Assigned To: Frank H. Ellenberger
Christian Stimming
Depends on:
Blocks:
 
 
Reported: 2012-07-26 19:31 UTC by Frank H. Ellenberger
Modified: 2018-06-29 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure.ac.patch (582 bytes, patch)
2012-08-04 00:19 UTC, Frank H. Ellenberger 		accepted-commit_now Details | Review

Description Frank H. Ellenberger 2012-07-26 19:31:50 UTC 
If you run configure --enable-python and the package python-devel is missing, make complains about the missing file python.h.
Ideally already configure should throw an error.

BTW configure.ac needs some rework before autoconf 2.68 can be used.

Until then probably some  AC_CHECK_HEADERS(python.h) would help.
Comment 1 John Ralls 2012-07-26 20:01:00 UTC 
OK. Why don't you just fix it?
Comment 2 Frank H. Ellenberger 2012-08-04 00:19:24 UTC 
Created attachment 220299 [details] [review]
configure.ac.patch

Re c1: Last week I was too tired, when I detected it.
And this is the first time, I touch the build system. While the patch gave me the desired result, I apply it not directly but ask for review, e.g. obsolets PKG_CHECK_MODULES(PYTHON, python >= 2.4 ... one of the following lines? Should the comment be shorter? Something else to improve?
Comment 3 Frank H. Ellenberger 2012-08-04 00:24:45 UTC 
I assume it should also be backported as the issue is also in the stable branch.
Comment 4 John Ralls 2012-08-04 00:27:02 UTC 
Comment on attachment 220299 [details] [review]
configure.ac.patch

OK. You can change the assignment to yourself when you create the bug to let everyone know that you intend to work on it.

Your patch is fine.
Comment 5 John Ralls 2012-08-04 00:28:07 UTC 
(In reply to comment #3)
> I assume it should also be backported as the issue is also in the stable
> branch.

Yes, of course.
Comment 6 Frank H. Ellenberger 2012-08-04 02:49:04 UTC 
r 22279: This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

r 22280: This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 7 John Ralls 2018-06-29 23:09:44 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=680671. Please update any external references or bookmarks.