After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680491 - Use generics for HashDataFunc and EqualDataFunc
Use generics for HashDataFunc and EqualDataFunc
Status: RESOLVED FIXED
Product: libgee
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: 0.7
Assigned To: libgee-maint
libgee-maint
Depends on:
Blocks: 679587
 
 
Reported: 2012-07-23 22:07 UTC by Evan Nemerson
Modified: 2012-08-06 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use generics for HashDataFunc and EqualDataFunc (8.69 KB, patch)
2012-07-23 22:07 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2012-07-23 22:07:17 UTC 
Created attachment 219536 [details] [review]
Use generics for HashDataFunc and EqualDataFunc

Currently HashDataFunc and EqualDataFunc use void*, which makes them a bit difficult to deal with in Vala.  This patch will switch them to generic delegates, which is an API break so it would be nice to merge this before the next stable release.

The patch may depend on attachment #219533 [details] (from bug #624005) in order to apply cleanly.
Comment 1 Maciej (Matthew) Piechotka 2012-07-24 07:41:54 UTC 
Let me look on it tomorrow but it looks good.
Comment 2 Maciej (Matthew) Piechotka 2012-07-30 00:07:54 UTC 
Review of attachment 219536 [details] [review]:

Looks good.
Comment 3 Maciej (Matthew) Piechotka 2012-08-06 01:32:56 UTC 
commit 5af26e45281b9ac518d9fcdde4b0bb4cf8563bdf
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Mon Jul 23 15:00:20 2012 -0700

    Use generics for HashDataFunc and EqualDataFunc, fixes bug 680491