After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680367 - GstDiscoverer on Gstreamer 0.11/1.0 is slower than on 0.10 and throws errors
GstDiscoverer on Gstreamer 0.11/1.0 is slower than on 0.10 and throws errors
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.11.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-21 11:07 UTC by Jens Georg
Modified: 2013-04-21 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jens Georg 2012-07-21 11:07:44 UTC
** (disco:13162): CRITICAL **: gst_audio_decoder_finish_frame: assertion `buf == NULL || gst_pad_has_current_caps (dec->srcpad)' failed

At least initially 0.10 seems to manage to extract mp3 files in ~0.005s while 1.0 needs ~0.05s. 

But 1.0 does not seem to suffer from bug 680366
Comment 1 Edward Hervey 2012-07-22 08:18:04 UTC
(In reply to comment #0)
> ** (disco:13162): CRITICAL **: gst_audio_decoder_finish_frame: assertion `buf
> == NULL || gst_pad_has_current_caps (dec->srcpad)' failed

  This should be fixed in git

> 
> At least initially 0.10 seems to manage to extract mp3 files in ~0.005s while
> 1.0 needs ~0.05s. 
> 

  I think this is due to the following commit (present in both 0.10 and 1.0):

commit e40ea309721eff8e1168844d81e2ca515e7acb6d
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Feb 14 19:23:27 2012 +0000

    discoverer: try harder to obtain a duration if we don't get one right away
    
    If we don't get a duration right away, set the pipeline to playing
    and sleep a bit, then try again. This is ugly, but the least worst
    we can do right now. The alternative would be to make parsers etc.
    return some bogus duration estimate even after only having pushed
    a single frame, for example.
    
    Fixes discoverer showing 0 durations for some mp3 and aac files
    (e.g. soweto-adts.aac).

---------
Comment 2 Tim-Philipp Müller 2012-12-25 17:48:55 UTC
Do you still get the errors/criticals?
Comment 3 Jens Georg 2012-12-26 21:12:35 UTC
Haven't seen them anymore
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2013-04-21 14:21:46 UTC
Looks like the CRITICALS are fixed.