GNOME Bugzilla – Bug 680348
Timed login is broken
Last modified: 2014-06-05 21:20:07 UTC
We now start the session conversation just-in-time upon clicking a username in the user list. This means we can't use the ConversationStarted signal anymore as a convenient way to know when the greeter is ready to hear the TimedLoginRequested signal. We're going to need to emit it at some other time, or drop it and have the client just read the config themselves. This patch was a quick hack and it didn't work. Need to figure out why.
Created attachment 219359 [details] [review] daemon: hack around timed login not working
Created attachment 219369 [details] [review] daemon: hack around timed login not working The greeter waits for the TimedLoginRequested signal to know when to initiated the timed login process. The slave used to send this signal shortly after the greeter called StartConversation. Now the greeter doesn't need to call StartConversation, since conversations are started implicitly. This means the slave doesn't have a good place to know when to emit the TimedLoginRequested signal. For now, emit the signal a couple of seconds after the greeter connects. This is a racy stop-gap. We're going to need to redo how timed login is orchestrated.
I pushed attachment 216369 [details] as a temporary stopgap
TimedLogin still broken on https://git.gnome.org/browse/gdm/commit/?id=9f0402c0 (3.11.92.1) - Gnome Continuous tests can't login
Created attachment 272579 [details] [review] manager: fix timed login There was some confusion over multiple competing enabled variables. This commit eliminates the confusion.
Attachment 272579 [details] pushed as 9f7a617 - manager: fix timed login
Created attachment 277974 [details] [review] manager: close up timed login race Previously we would emit the timed-login-requested signal after the client connects, which might be before it was listening for the signal. Now we only emit the signal in direct response to a GetTimedLoginDetails call, which we make implicitly when the appropiate proxy interface is set up.
people are still seeing timed login not working sporadically. I haven't been able to reproduce, but this commit should close up the race.
Comment on attachment 277974 [details] [review] manager: close up timed login race Attachment 277974 [details] pushed as e24484f - manager: close up timed login race