After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680271 - Use pkcs11.h from p11-kit instead of shipping a copy
Use pkcs11.h from p11-kit instead of shipping a copy
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: gck
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-07-19 18:43 UTC by Evan Nemerson
Modified: 2019-03-23 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use p11-kit/pkcs11.h instead of shipping a copy with gck. (49.45 KB, patch)
2012-07-19 18:45 UTC, Evan Nemerson
accepted-commit_now Details | Review

Description Evan Nemerson 2012-07-19 18:43:15 UTC
GCK already depends on p11-kit, so it makes sense to use the pkcs11.h which is shpped with it instead of shipping its own copy.
Comment 1 Evan Nemerson 2012-07-19 18:45:15 UTC
Created attachment 219258 [details] [review]
Use p11-kit/pkcs11.h instead of shipping a copy with gck.
Comment 2 Stef Walter 2012-07-24 04:01:23 UTC
Review of attachment 219258 [details] [review]:

Looks good. Thanks.
Comment 3 Evan Nemerson 2012-08-05 02:01:53 UTC
commit cf049d1b22d5e2cdf56ceccdaaa0023e40486287
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Thu Jul 19 11:43:49 2012 -0700

    Use p11-kit/pkcs11.h instead of shipping a copy with gck.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680271