After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680093 - [0.11] playbin: aspect ratio gets messed up with ximagesink/xvimagesink
[0.11] playbin: aspect ratio gets messed up with ximagesink/xvimagesink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.11.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-17 12:41 UTC by Tim-Philipp Müller
Modified: 2012-07-24 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2012-07-17 12:41:21 UTC 
gst-launch-1.0 uri=http://people.freedesktop.org/~tpm/samples/bbcnews2.m2t

However, gst-launch-1.0 file:///home/tpm/bbcnews2.m2t ! tsdemux ! mpeg2dec ! videoscale ! videoconvert ! xvimagesink and variations work fine.

Totem using playbin and cluttersink also works fine.
Comment 1 Edward Hervey 2012-07-18 13:32:48 UTC 
Even simpler way to make it fail : gst-launch-1.0 videotestsrc ! video/x-raw,width=360,height=270,pixel-aspect-ratio=4/3 ! xvimagesink force-aspect-ratio=True

The resulting video should be displayed as widescreen (360x270 with a PAR of 4/3, results in a DAR of 16/9).

Trying the same thing with 0.10 results in a properly displayed (widescreen) video.
Comment 2 Wim Taymans 2012-07-24 10:05:00 UTC 
commit 9572ec0481e57de688c9307ec3fad256fee110f9
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Jul 24 12:02:34 2012 +0200

    xvimagesink: calculate target rectangle correctly
    
    Use the negotiated size and PAR to center the image into the target window.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=680093
Comment 3 Wim Taymans 2012-07-24 10:09:11 UTC 
Above fix fixes the playbin error. The reason why it doesn't happen with an equivalent manual launch line is because the error was only triggered when force-aspect-ratio is set to TRUE on the video sink, which playbin does.