GNOME Bugzilla – Bug 679938
[gapless] Repeat always on
Last modified: 2014-02-04 19:49:21 UTC
Originally reported at: https://bugs.launchpad.net/bugs/990831 I use ubuntu 12.04 amd64 and banshee 2.4.0-2ubuntu1. I have repeat option off (the default setting, I haven't changed it), but when the last song of an album is finished then banshee automatic plays the first one.
Hi Chow, it's me again :) Did you report this because you also reproduce it, or just to report it upstream? If it's the former, then can you tell me if it's OGG specific? Thanks!
Just forwarding upstream, I think. Looks like the bug has been marked a duplicate of https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/709860, but I see your comment from 8 hours ago there. :)
Are you able to reproduce it anyway?
Based on https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/709860/comments/9 I'm adding the [gapless] token in the summary.
Configuration: - banshee git 2.6 stable at 20140125[1] - gapless set up - no repeat set up Test: - playing one mp3: it's played just one time - playing one ogg: seems to play infinite times - playing one wma: seems to play infinite times - playing one wav: it's played just one time [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=6453707 Feel free to ask me another tests with same or newer builds.
Created attachment 267460 [details] [review] Proposed patch Thanks for testing Ismael! Can you test this patch?
Review of attachment 267460 [details] [review]: Configuration: - banshee git 2.6 stable at 20140125 + patch[1] - gapless set up - no repeat set up Tests: - playing one wav: it's played just one time - playing one ogg: it's played just one time - playing one mp3: it's played just one time - playing one wma: it's played just one time Conclusion: - in these scenarios the patch seems to work always - in this test it hasn't scrobbled to lastfm :-m [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=6469789
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report. (Fixed in master and the stable-2.6 branch, which means the fix will be in 2.9.1 and 2.6.2.) (In reply to comment #8) > Conclusion: > - in this test it hasn't scrobbled to lastfm :-m Please do more tests than one, and if you confirm that lastfm scrobbling is broken after this fix and not before this fix, then create a new bug please (I added a unit test for this bug, so if lastfm gets broken because of this, we will need to add more unit tests for lastfm). Thanks
Ok. Seems my tests where done with extremely short files so, seems to me, they didn't reach the threshold of the audioscrobbler. So, yes, it's scrobbles. The bad news: in the specific case of a single song to play it scrobbles twice :-)
(In reply to comment #10) > The bad news: in the specific case of a single song to play it scrobbles twice > :-) I think there's already a bug report open for that case. Please look for it and once you find it, cc Phil Trimble to it, because he usually investigates and fixes LastFM bugs very efficiently.