After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679858 - "Displays" is registering dual monitors as "laptop" when using fglrx
"Displays" is registering dual monitors as "laptop" when using fglrx
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-13 13:44 UTC by michele.giacomoli
Modified: 2012-07-16 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A screenshot showing the problem (44.67 KB, image/png)
2012-07-13 13:44 UTC, michele.giacomoli
Details
xrand -q output (1.68 KB, text/plain)
2012-07-13 18:36 UTC, michele.giacomoli
Details

Description michele.giacomoli 2012-07-13 13:44:29 UTC
Created attachment 218725 [details]
A screenshot showing the problem

After installing the fglrx drivers, in the "Displays" options both monitors are showing up as "laptop". When using the radeon drivers each monitor is recognized with the proper name, but with the proprietary drivers they both say "laptop" and there is no visual color difference to indicate differences between the two.

It would be nice to see the two monitors registering as their proper names and differentiation.

It seems the problem to be related to these changes: http://git.gnome.org/browse/gnome-desktop/commit/?id=ead1b3478c86e80237c79c6f618d8187b6cd9eeb

I've attached a screenshot showing the problem.
Comment 1 Bastien Nocera 2012-07-13 13:50:35 UTC
What's the output of "xrandr -q" with that driver?
Comment 2 michele.giacomoli 2012-07-13 14:10:58 UTC
At this moment I have no monitors to try with, I'll try this evening.
Comment 3 michele.giacomoli 2012-07-13 18:36:20 UTC
Created attachment 218750 [details]
xrand -q output
Comment 4 Bastien Nocera 2012-07-16 12:07:21 UTC
The patch you mentioned in comment 0 needs to be reverted.
Comment 5 michele.giacomoli 2012-07-16 13:22:27 UTC
Ok, but if we revert the patch, we also reopen the bug fixed by this patch...

I'm not a professional developer, i saw that the patch consists in attaching another condition in an if expression:

strstr (output->name, "DFP")

Can the program know if it is running on a mac or not? If so, couldn't we modify the code in order to apply that condition ONLY if the pc is a mac?? For example:
from: 
   strstr (output->name, "DFP") 
to something like this:
   (strstr (output->name, "DFP") && some_variable_that_make_me_know_it's_a_mac)

It's ugly, I know, but it doesn't reopen any bug.
Comment 6 Bastien Nocera 2012-07-16 14:28:31 UTC
(In reply to comment #5)
> Ok, but if we revert the patch, we also reopen the bug fixed by this patch...

We don't, read bug 672030 carefully...
Comment 7 Bastien Nocera 2012-07-16 14:32:43 UTC
commit e4ec79dd9ce45e4f2288da1e818a93e38a6e8949
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Jul 16 15:30:33 2012 +0100

    gnome-rr: Don't mark DFP outputs as internal
    
    Too many false positives, and the bug that it was supposed to fix,
    on the MacBook Pro, wasn't actually fixed by that check.
    
    See:
    https://bugzilla.gnome.org/show_bug.cgi?id=679858
    and:
    https://bugzilla.gnome.org/show_bug.cgi?id=672030
Comment 8 michele.giacomoli 2012-07-16 16:27:31 UTC
Ok, I understand. Thank you Bastien for the fast reply and fix.

Forgive my ignorance, but will this "fix" be applied also in GNOME 3.4.x branch?