After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679807 - flacparse: check_valid_frame fails on valid flac file
flacparse: check_valid_frame fails on valid flac file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-12 15:31 UTC by D.S. (Spider) Ljungmark
Modified: 2012-07-13 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description D.S. (Spider) Ljungmark 2012-07-12 15:31:41 UTC
I have a flac file that checks out as valid with "flac -t" and plays in mplayer (ffmpeg / libavcodec audio decoder)  without issue, but that fails in gstreamer flac decoders.

This happens both on 0.10.x git head ( jhbuild ) and released ( Fedora 17 current )

The error is around 2 minutes into the song:
[spider@Waves]~% totem 01\ -\ Drag\ Ropes.flac 
0:02:07.941712438 13642      0x1a26320 ERROR              flacparse gstflacparse.c:785:gst_flac_parse_check_valid_frame:<flacparse0> Giving up on invalid frame (65536 bytes)
Comment 1 D.S. (Spider) Ljungmark 2012-07-12 15:39:12 UTC
Too big to upload, putting it temporarily at :
  http://www.skuggor.se/files/gst-breaks.flac
Comment 2 Mark Nauwelaerts 2012-07-13 13:35:10 UTC
commit 32cddf61d02ec0538342e9def0c5d37f44ea9ee6
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Fri Jul 13 14:43:31 2012 +0200

    flacparse: avoid some more frame misparsing by additional header sanity check
    
    ... using a required constant blocking_strategy bit.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=679807