After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679674 - Remove trailing commas from enums
Remove trailing commas from enums
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-10 10:40 UTC by Murray Cumming
Modified: 2012-07-11 08:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-core-Avoid-pedantic-compiler-warnings-with-C.patch (3.38 KB, patch)
2012-07-10 10:40 UTC, Murray Cumming 		committed Details | Review

Description Murray Cumming 2012-07-10 10:40:15 UTC 
Created attachment 218407 [details] [review]
0001-core-Avoid-pedantic-compiler-warnings-with-C.patch

This patch lets me use -Wpedantic with g++ when including grilo headers. Other GNOME libraries generally don't have these trailing commas.
Comment 1 Juan A. Suarez Romero 2012-07-11 08:50:23 UTC 
Comment on attachment 218407 [details] [review]
0001-core-Avoid-pedantic-compiler-warnings-with-C.patch

I've applied the same changes also to other files
Comment 2 Juan A. Suarez Romero 2012-07-11 08:50:46 UTC 
commit b5382e28d6765301cc64271e974cc1af35c8ceac
Author: Murray Cumming <murrayc@murrayc.com>
Date:   Tue Jul 10 12:38:03 2012 +0200

    core: Avoid pedantic compiler warnings with C++.
    
    g++ complains about trailing commas in enums when using
    -Wpedantic.
    
    This fixes https://bugzilla.gnome.org/show_bug.cgi?id=679674
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 autogen.sh                  |    2 +-
 libs/net/grl-net-wc.c       |    2 +-
 libs/net/grl-net-wc.h       |    2 +-
 src/grl-caps.h              |    2 +-
 src/grl-media-source.c      |    4 ++--
 src/grl-media-source.h      |    2 +-
 src/grl-metadata-source.c   |    2 +-
 src/grl-metadata-source.h   |    4 ++--
 src/grl-operation-options.h |    2 +-
 src/grl-plugin-registry.c   |    2 +-
 src/grl-plugin-registry.h   |    2 +-
 tools/grilo-test-ui/main.c  |   10 +++++-----
 12 files changed, 18 insertions(+), 18 deletions(-)