GNOME Bugzilla – Bug 679643
core-3.6: Add ibus dependency for g-s-d and g-c-c
Last modified: 2012-07-13 12:25:27 UTC
Please see the attached patch. I'd like to stress that as soon as ibus upstream[1] gets the patch in [2] (or something along those lines) merged and does a release we'll change jhbuild to get ibus from a tarball to keep it in line with other external dependencies. [1] https://github.com/ibus/ibus [2] http://code.google.com/p/ibus/issues/detail?id=1476
Created attachment 218352 [details] [review] core-3.6: Add ibus dependency for g-s-d and g-c-c Also add ibus-pinyin, ibus-anthy and ibus-hangul engines as suggests for g-c-c to make it actually useful.
Created attachment 218439 [details] [review] core-3.6: Add ibus dependency for g-s-d and g-c-c -- Changed the ibus github repo branch to 'patches' instead of the default 'master'.
We'll discuss this at the next release-team meeting.
What are the tarball download locations for the modules we'll get from git? (ibus, libpinyin, ibus-pinyin) Also, who should we contact if we need some tarball?
http://code.google.com/p/ibus/ has ibus and ibus-pinyin tarballs Our primary contact so far has been Takao Fujiwara, tfujiwar@redhat.com, who is working on IBus in Red Hat i18n team.
Created attachment 218672 [details] [review] core-3.6: Add ibus dependency for g-s-d and g-c-c -- We finally have an ibus tarball snapshot that we can use so I've changed this patch to use only tarballs for all the new external modules. I still expect to have updated tarballs for ibus-pinyin and ibus-anthy shortly to fix a cosmetic issue (symbol for pinyin in the gnome-shell menu) and to include .desktop files for theis engines' setup utilities that we are launching from g-c-c. I'm told those should show up soon. Anyway, what's here on this patch now fully works.
Looks good to me, thanks.
Review of attachment 218672 [details] [review]: ok
Created attachment 218709 [details] [review] core-3.6: Add ibus dependency for g-s-d and g-c-c -- ibus-anthy has a new snapshot tarball now, updated.
Review of attachment 218709 [details] [review]: even better
Attachment 218709 [details] pushed as 450cc38 - core-3.6: Add ibus dependency for g-s-d and g-c-c