After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679430 - vm-creator: Unhook from state-changed signal on machine deletion
vm-creator: Unhook from state-changed signal on machine deletion
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-07-05 02:36 UTC by Zeeshan Ali
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vm-creator: Unhook from state-changed signal on machine deletion (814 bytes, patch)
2012-07-05 02:36 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-07-05 02:36:57 UTC 
Unhook from state-changed signal on machine deletion.
Comment 1 Zeeshan Ali 2012-07-05 02:36:59 UTC 
Created attachment 218069 [details] [review]
vm-creator: Unhook from state-changed signal on machine deletion
Comment 2 Christophe Fergeau 2012-07-05 12:48:11 UTC 
Why?
Comment 3 Zeeshan Ali 2012-07-05 13:39:52 UTC 
(In reply to comment #2)
> Why?

We want to continue listening to state change events on a deleted machine? :)
Comment 4 Christophe Fergeau 2012-07-05 13:41:55 UTC 
I mean, the changelog is useless, it's paraphrasing the vala code.
Comment 5 Zeeshan Ali 2012-07-05 15:02:06 UTC 
(In reply to comment #4)
> I mean, the changelog is useless, it's paraphrasing the vala code.

For such trivial and obvious commits, thats natural but feel free to suggest something better.
Comment 6 Christophe Fergeau 2012-07-05 15:11:11 UTC 
If it's a trivial and obvious commit that you just noticed when reading the code, then it should go in the log. If it was causing a bug and you made this change to fix this, then this should go in the log as well. The log reader shouldn't have to guess this, the impact of the change, ...
Comment 7 Zeeshan Ali 2012-07-05 15:27:59 UTC 
Attachment 218069 [details] pushed as d520627 - vm-creator: Unhook from state-changed signal on machine deletion