After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679425 - telepathy connection new deprecated
telepathy connection new deprecated
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-04 23:11 UTC by Jeremy Whiting
Modified: 2012-07-05 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port from tp_connection_new to TelepathySimpleClientFactory (2.38 KB, patch)
2012-07-04 23:11 UTC, Jeremy Whiting 		none Details | Review
Updated patch after review. (8.37 KB, patch)
2012-07-05 15:35 UTC, Jeremy Whiting 		none Details | Review

Description Jeremy Whiting 2012-07-04 23:11:31 UTC 
Created attachment 218061 [details] [review]
Port from tp_connection_new to TelepathySimpleClientFactory

Since telepathy_connection_new has been deprecated I created a patch that ports folks to telepathy simple client factory.
Comment 1 Xavier Claessens 2012-07-05 08:22:09 UTC 
utils.c comes from telepathy-glib, please just copy that file, it has been ported already.

in backend.c, you can take the factory from priv->account_manager, no need to create a new one. See tp_tests_backend_set_up().
Comment 2 Xavier Claessens 2012-07-05 08:23:27 UTC 
Note that you leak the factory in both functions.
Comment 3 Jeremy Whiting 2012-07-05 15:35:20 UTC 
Created attachment 218105 [details] [review]
Updated patch after review.

Xavier,

Thanks for the quick review of the last patch.  Here I've updated it as per your feedback.  Do I need to unref the factory at the end of tp_tests_backend_add_account ?
Comment 4 Xavier Claessens 2012-07-05 19:15:38 UTC 
(In reply to comment #3)
> Thanks for the quick review of the last patch.  Here I've updated it as per
> your feedback.  Do I need to unref the factory at the end of
> tp_tests_backend_add_account ?

no, tp_proxy_get_factory() does not return a ref.

Your patch seems good, +1