After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679332 - Handle Adium themes that use .AdiumMessagestyle
Handle Adium themes that use .AdiumMessagestyle
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Preferences
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-07-03 14:20 UTC by Debarshi Ray
Modified: 2012-07-04 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy-theme-manager: handle Adium themes that use .AdiumMessagestyle (1.70 KB, patch)
2012-07-03 14:27 UTC, Debarshi Ray 		accepted-commit_now Details | Review
empathy-theme-manager: handle Adium themes that use .AdiumMessagestyle (2.99 KB, patch)
2012-07-03 14:43 UTC, Debarshi Ray 		rejected Details | Review

Description Debarshi Ray 2012-07-03 14:20:31 UTC 
Some Adium themes (eg., http://www.adiumxtras.com/index.php?a=xtras&xtra_id=17) use .AdiumMessagestyle instead of AdiumMessageStyle as the suffix. We should handle them.
Comment 1 Debarshi Ray 2012-07-03 14:27:19 UTC 
Created attachment 217938 [details] [review]
empathy-theme-manager: handle Adium themes that use .AdiumMessagestyle
Comment 2 Guillaume Desmottes 2012-07-03 14:31:32 UTC 
Review of attachment 217938 [details] [review]:

++
Comment 3 Debarshi Ray 2012-07-03 14:43:53 UTC 
Created attachment 217939 [details] [review]
empathy-theme-manager: handle Adium themes that use .AdiumMessagestyle

I missed a few other places. Without them there is no crash, but the themes can't be found and the Classic fallback is used.
Comment 4 Guillaume Desmottes 2012-07-04 14:45:30 UTC 
Review of attachment 217939 [details] [review]:

As discussed on IRC, I prefer to simply ignore those themes as they violate the Adium spec. Pushing my fix to master.