After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679153 - constraints: fix mem leak in meta_window_constrain()
constraints: fix mem leak in meta_window_constrain()
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-29 17:30 UTC by Pavel Vasin
Modified: 2012-07-08 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
constraints: fix mem leak in meta_window_constrain() (828 bytes, patch)
2012-06-29 17:30 UTC, Pavel Vasin 		needs-work Details | Review
constraints: fix mem leak in meta_window_constrain() (1.66 KB, patch)
2012-07-07 08:43 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-06-29 17:30:42 UTC 
Created attachment 217647 [details] [review]
constraints: fix mem leak in meta_window_constrain()

.
Comment 1 Owen Taylor 2012-07-06 18:02:18 UTC 
Review of attachment 217647 [details] [review]:

Thanks for the patch! I think it's really ugly to duplicate the complicated check in two places - and prone to new problems like this. Can you add a borders_allocated boolean to ConstraintInfo?
Comment 2 Pavel Vasin 2012-07-07 08:43:59 UTC 
Created attachment 218212 [details] [review]
constraints: fix mem leak in meta_window_constrain()

with boolean in ConstraintInfo
Comment 3 Owen Taylor 2012-07-08 15:57:13 UTC 
Pushed, thanks!

Attachment 218212 [details] pushed as 255347f - constraints: fix mem leak in meta_window_constrain()