After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679091 - [PATCH] agent asks for password when interaction isn't allowed
[PATCH] agent asks for password when interaction isn't allowed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-28 22:10 UTC by Dan Williams
Modified: 2012-06-29 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't ask for always-ask passwords when interaction isn't allowed (1.03 KB, patch)
2012-06-28 22:11 UTC, Dan Williams
accepted-commit_now Details | Review

Description Dan Williams 2012-06-28 22:10:14 UTC
If a connection has no passwords yet (was preloaded, or something like that) and the password is marked "always-ask", the shell will ask for it even when it shouldn't.  Like trying to edit that connection from nm-connection-editor.  Clearly a typo in the original code.
Comment 1 Dan Williams 2012-06-28 22:11:43 UTC
Created attachment 217568 [details] [review]
Don't ask for always-ask passwords when interaction isn't allowed
Comment 2 Colin Walters 2012-06-28 22:14:00 UTC
Review of attachment 217568 [details] [review]:

Nice.
Comment 3 Dan Williams 2012-06-29 14:32:49 UTC
Pushed.