After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679074 - schemas: Add a 'xkb-options' key to org.gnome.desktop.input-sources
schemas: Add a 'xkb-options' key to org.gnome.desktop.input-sources
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 679075
 
 
Reported: 2012-06-28 16:27 UTC by Rui Matos
Modified: 2012-08-16 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
schemas: Add a 'xkb-options' key to org.gnome.desktop.input-sources (1.07 KB, patch)
2012-06-28 16:27 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2012-06-28 16:27:33 UTC
See patch.
Comment 1 Rui Matos 2012-06-28 16:27:35 UTC
Created attachment 217546 [details] [review]
schemas: Add a 'xkb-options' key to org.gnome.desktop.input-sources
Comment 2 Matthias Clasen 2012-06-28 19:17:10 UTC
Review of attachment 217546 [details] [review]:

Does it make sense to store options independent of layout+variant ?
Comment 3 Rui Matos 2012-06-29 12:55:10 UTC
(In reply to comment #2)
> Does it make sense to store options independent of layout+variant ?

I think it does but I'm not 100% sure. If we had an independent set of options for each input source would the user have to configure, say the compose key, for each one of them?

Or we could have 2 levels of options, some global and some tied to an input source? Looking at the available options, the vast majority seems to only make sense globally. It's only a handful of them that could make sense tied to an input source like the 3 Japanese ones. I wonder how useful they are though.
Comment 4 Bastien Nocera 2012-06-29 13:21:43 UTC
Those are xkb-options, they're options just for xkb layouts, so it looks fine to me to only have one.
libgnomekbd only had global xkb options as well.
Comment 5 Bastien Nocera 2012-06-29 13:23:33 UTC
Review of attachment 217546 [details] [review]:

Looks fine to me. Are you sure "as" is the best container to apply those to XKB?
Comment 6 Matthias Clasen 2012-06-29 13:55:52 UTC
(In reply to comment #4)
> Those are xkb-options, they're options just for xkb layouts, so it looks fine
> to me to only have one.
> libgnomekbd only had global xkb options as well.

Ah, OK then
Comment 7 Christian Persch 2012-06-29 15:06:20 UTC
(In reply to comment #5)
> Review of attachment 217546 [details] [review]:
> 
> Looks fine to me. Are you sure "as" is the best container to apply those to
> XKB?

Also, if we do go with "as", can you use <choices> to enumerate the available option values?
Comment 8 Bastien Nocera 2012-06-29 15:11:38 UTC
(In reply to comment #7)
> (In reply to comment #5)
> > Review of attachment 217546 [details] [review] [details]:
> > 
> > Looks fine to me. Are you sure "as" is the best container to apply those to
> > XKB?
> 
> Also, if we do go with "as", can you use <choices> to enumerate the available
> option values?

There's a _lot_ of them. There's at least 200 listed in /usr/share/X11/xkb/rules/base.
Comment 9 Rui Matos 2012-07-06 16:10:12 UTC
(In reply to comment #5)
> Looks fine to me. Are you sure "as" is the best container to apply those to
> XKB?

The API finally requires the options to be sent to the X server as a string like "option1,option2,option3" so yes, I think "as" is fine for that.
Comment 10 Christian Persch 2012-07-06 17:31:30 UTC
(In reply to comment #8)
> > Also, if we do go with "as", can you use <choices> to enumerate the available
> > option values?
> 
> There's a _lot_ of them. There's at least 200 listed in
> /usr/share/X11/xkb/rules/base.

Having the choices listed in the schema is a huge help when using dconf-editor or gsettings tool. Even, and *especially*, if there are "lots" of them :-)
Comment 11 Bastien Nocera 2012-08-16 14:06:12 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > > Also, if we do go with "as", can you use <choices> to enumerate the available
> > > option values?
> > 
> > There's a _lot_ of them. There's at least 200 listed in
> > /usr/share/X11/xkb/rules/base.
> 
> Having the choices listed in the schema is a huge help when using dconf-editor
> or gsettings tool. Even, and *especially*, if there are "lots" of them :-)

Maybe we could come up with something auto-generated. I wouldn't block this bug on it though.
Comment 12 Bastien Nocera 2012-08-16 14:25:03 UTC
Filed bug 682008 about the <choices> stuff.