After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678951 - Missing trailing semicolon in desktop file Spanish translation
Missing trailing semicolon in desktop file Spanish translation
Status: RESOLVED FIXED
Product: bluefish
Classification: Other
Component: build system
development (SVN TRUNK)
Other Linux
: Low minor
: 2.2.4
Assigned To: Daniel Leidert
Daniel Leidert
Depends on:
Blocks:
 
 
Reported: 2012-06-27 09:08 UTC by Paul Howarth
Modified: 2012-06-28 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing semicolon (315 bytes, patch)
2012-06-27 09:08 UTC, Paul Howarth 		none Details | Review

Description Paul Howarth 2012-06-27 09:08:59 UTC 
Created attachment 217357 [details] [review]
Add missing semicolon

The missing semicolon causes desktop-file-validate to reject the consolidated desktop file with the translations added.

Patch attached.

This affects 2.2.3 as released.
Comment 1 Olivier Sessink 2012-06-27 19:15:04 UTC 
Paul,

what is the impact of this issue? is all of the .desktop file rejected on all languages? or is just the category in the menu for spanish users affected?
Comment 2 Daniel Leidert 2012-06-27 21:46:37 UTC 
It's a validation issue, that shouldn't have any impact.
Comment 3 Paul Howarth 2012-06-27 22:46:14 UTC 
(In reply to comment #2)
> It's a validation issue, that shouldn't have any impact.

Agreed. In Fedora we run desktop-file-validate or equivalent when packaging desktop files, and that caused the build to fail. It doesn't happen on a standard install.
Comment 4 Olivier Sessink 2012-06-28 05:20:11 UTC 
so we don't need to re-release 2.2.3, agreed?

I've fixed it in SVN already.

b.t.w.can we automate this check in make distcheck?
Comment 5 Paul Howarth 2012-06-28 08:19:50 UTC 
(In reply to comment #4)
> so we don't need to re-release 2.2.3, agreed?

Fine by me.

> I've fixed it in SVN already.
> 
> b.t.w.can we automate this check in make distcheck?

Should be possible I'd have though. Just need to assemble the desktop file from the translations and run desktop-file-validate on it.
Comment 6 Daniel Leidert 2012-06-28 22:33:13 UTC 
Fixed in r7551.