After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678902 - Ugly error message when boxes creation fails
Ugly error message when boxes creation fails
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on: 678894
Blocks:
 
 
Reported: 2012-06-26 16:30 UTC by Christophe Fergeau
Modified: 2016-03-31 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bad looking error message (28.75 KB, image/png)
2012-06-26 16:30 UTC, Christophe Fergeau 		  Details
wizard: Turn a check into a return_if_fail (862 bytes, patch)
2012-07-04 18:55 UTC, Zeeshan Ali 		none Details | Review
wizard: Friendlier error in the UI on review failure (1023 bytes, patch)
2012-07-04 18:55 UTC, Zeeshan Ali 		none Details | Review
wizard: Turn a check into return_val_if_fail (864 bytes, patch)
2012-07-05 22:50 UTC, Zeeshan Ali 		committed Details | Review
wizard: Friendlier error in the UI on review failure (1023 bytes, patch)
2012-07-05 22:51 UTC, Zeeshan Ali 		committed Details | Review

Description Christophe Fergeau 2012-06-26 16:30:59 UTC 
Created attachment 217311 [details]
bad looking error message

Errors should not happen, but I just got the error in the attached screenshot, which is very unnice to throw at one user's face when everything is already going bad. I think this used to just be "Boxes creation failed". This may be related to #674209 landing.
Comment 1 Zeeshan Ali 2012-07-04 18:55:43 UTC 
Created attachment 218039 [details] [review]
wizard: Turn a check into a return_if_fail
Comment 2 Zeeshan Ali 2012-07-04 18:55:47 UTC 
Created attachment 218040 [details] [review]
wizard: Friendlier error in the UI on review failure

The error string is based on the one we display when create() fails.
Comment 3 Zeeshan Ali 2012-07-04 18:56:59 UTC 
Patches are on top of unmerged patches in bug#678894.
Comment 4 Zeeshan Ali 2012-07-05 22:50:25 UTC 
Created attachment 218124 [details] [review]
wizard: Turn a check into return_val_if_fail

Slightly more accurate log
Comment 5 Zeeshan Ali 2012-07-05 22:51:05 UTC 
Created attachment 218125 [details] [review]
wizard: Friendlier error in the UI on review failure

Rebased on master.
Comment 6 Marc-Andre Lureau 2012-07-06 20:40:45 UTC 
Review of attachment 218124 [details] [review]:

ack
Comment 7 Marc-Andre Lureau 2012-07-06 20:41:02 UTC 
Review of attachment 218125 [details] [review]:

ack
Comment 8 Zeeshan Ali 2012-07-07 14:23:10 UTC 
Attachment 218124 [details] pushed as 4533c16 - wizard: Turn a check into return_val_if_fail
Attachment 218125 [details] pushed as b8cd56a - wizard: Friendlier error in the UI on review failure