After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678876 - Fix parsing of CSS stylesheet with gtk+ 3.4
Fix parsing of CSS stylesheet with gtk+ 3.4
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-26 12:55 UTC by Christophe Fergeau
Modified: 2016-03-31 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix parsing of CSS stylesheet with gtk+ 3.4 (1.17 KB, patch)
2012-06-26 12:55 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2012-06-26 12:55:23 UTC 
gtk+ 3.4 expects the horizontal and vertical offsets of text-shadow
and icon-shadow CSS properties to be unitless otherwise it fails
to parse them, and it returns an error parsing the whole CSS stylesheet
("Horizontal and vertical offsets are required").
This causes GNOME Boxes to be wrongly styled/themed, and looks ugly.
This will be fixed with gtk+ 3.6, but in the 3.4 series, let's go
with an easy fix and remove units from these properties.
Comment 1 Christophe Fergeau 2012-06-26 12:55:24 UTC 
Created attachment 217283 [details] [review]
Fix parsing of CSS stylesheet with gtk+ 3.4
Comment 2 Christophe Fergeau 2012-06-26 13:02:03 UTC 
NB: this is mainly aimed at the gnome-3-4 branch, I think master is fine.
Comment 3 Zeeshan Ali 2012-06-26 13:03:35 UTC 
Review of attachment 217283 [details] [review]:

ACK but remember to push it to gnome-3-4 branch only.
Comment 4 Christophe Fergeau 2012-06-29 08:01:17 UTC 
I've pushed this a while ago:
http://git.gnome.org/browse/gnome-boxes/commit/?h=gnome-3-4&id=f973b38e04d7b082ffe8d68de28332792744e8be