After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678772 - isomp4/qtdemux: Try to seek upstream before dropping seek push event
isomp4/qtdemux: Try to seek upstream before dropping seek push event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.31
Other All
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-06-25 09:24 UTC by David Corvoysier
Modified: 2012-06-28 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.13 KB, patch)
2012-06-25 09:24 UTC, David Corvoysier 		needs-work Details | Review
New patch with upstream seek applied first (1.33 KB, patch)
2012-06-28 09:39 UTC, David Corvoysier 		committed Details | Review

Description David Corvoysier 2012-06-25 09:24:04 UTC 
Created attachment 217183 [details] [review]
Proposed patch

When it cannot perform a seek in push mode, the qtdemux should forward the event upstream instead of dropping it.
Comment 1 Sebastian Dröge (slomo) 2012-06-25 09:36:14 UTC 
Review of attachment 217183 [details] [review]:

It should *first* try upstream to seek, and only if upstream fails fall back to its own seek logic
Comment 2 David Corvoysier 2012-06-28 09:39:02 UTC 
Created attachment 217487 [details] [review]
New patch with upstream seek applied first

Here is a new patch addressing your comment.
Comment 3 Sebastian Dröge (slomo) 2012-06-28 12:45:52 UTC 
commit c06cb7c14578c9cb0dd6325714bd2b9e10adeaea
Author: David Corvoysier <david.corvoysier@orange.com>
Date:   Thu Jun 28 11:29:55 2012 +0200

    isomp4: Try to seek upstream before processing seek push event
    
    When it receives a seek in push mode, the qtdemux should first try to push the event upstream, and only if upstream fails fall back to
    its own seek logic.